Page MenuHomePhabricator
Differential D21157

Mark "low importance" and "owned" changes in the filetree
ClosedPublic
Actions

Authored by epriestley on Apr 22 2020, 6:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 23, 10:50 PM
Unknown Object (File)
Mon, Feb 17, 3:12 PM
Unknown Object (File)
Sun, Feb 9, 9:04 AM
Unknown Object (File)
Sun, Feb 9, 9:04 AM
Unknown Object (File)
Sun, Feb 9, 9:04 AM
Unknown Object (File)
Thu, Jan 30, 3:14 PM
Unknown Object (File)
Jan 25 2025, 8:09 AM
Unknown Object (File)
Jan 25 2025, 7:17 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13516: Remove the "filetree" setting (so it's always enabled for everyone)
Commits
rPa72a66caa833: Mark "low importance" and "owned" changes in the filetree
Summary

Ref T13516. Mark low-importance changes (generated code, deleted files) and owned-with-authority changes in the filetree.

Test Plan

Screen Shot 2020-04-22 at 10.59.45 AM.png (1×1 px, 533 KB)

Diff Detail

Repository
rP Phabricator
Branch
flank1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24191
Build 33319: Run Core Tests
Build 33318: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 22 2020, 6:00 PM
Harbormaster completed remote builds in B24191: Diff 50373.Apr 22 2020, 6:01 PM
epriestley requested review of this revision.Apr 22 2020, 6:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2020, 6:22 PM
Closed by commit rPa72a66caa833: Mark "low importance" and "owned" changes in the filetree (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPa72a66caa833: Mark "low importance" and "owned" changes in the filetree.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
differential/
controller/
11 lines
engine/
1 line
mail/
5 lines
storage/
52 lines
view/
2 lines
webroot/
rsrc/
css/
application/
diff/
19 lines
js/
application/
diff/
8 lines
23 lines
3 lines

Diff 50373

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/engine/DifferentialFileTreeEngine.php

Loading...
View Options

src/applications/differential/mail/DifferentialInlineCommentMailView.php

Loading...
View Options

src/applications/differential/storage/DifferentialChangeset.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetDetailView.php

Loading...
View Options

webroot/rsrc/css/application/diff/diff-tree-view.css

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffPathView.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffTreeView.js

Loading...
Phabricator · Built by Phacility