Page MenuHomePhabricator
Differential D21153

Roughly style the new "flank" paths UI
ClosedPublic
Actions

Authored by epriestley on Apr 21 2020, 9:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 9:03 AM
Unknown Object (File)
Sun, Feb 9, 9:03 AM
Unknown Object (File)
Sun, Feb 9, 9:03 AM
Unknown Object (File)
Sat, Feb 1, 4:27 PM
Unknown Object (File)
Mon, Jan 27, 12:44 PM
Unknown Object (File)
Sat, Jan 25, 7:15 AM
Unknown Object (File)
Sat, Jan 25, 7:15 AM
Unknown Object (File)
Sat, Jan 25, 7:15 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13516: Remove the "filetree" setting (so it's always enabled for everyone)
Commits
rPba8071bbef50: Roughly style the new "flank" paths UI
Summary

Ref T13516. Apply basic UI styling to the new UI and make some more interaction work.

Test Plan

Screen Shot 2020-04-21 at 2.01.52 PM.png (1×1 px, 426 KB)

Diff Detail

Repository
rP Phabricator
Branch
flank4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24180
Build 33304: Run Core Tests
Build 33303: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 21 2020, 9:04 PM
Harbormaster completed remote builds in B24180: Diff 50362.Apr 21 2020, 9:05 PM
epriestley requested review of this revision.Apr 21 2020, 9:05 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2020, 3:31 PM
Closed by commit rPba8071bbef50: Roughly style the new "flank" paths UI (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPba8071bbef50: Roughly style the new "flank" paths UI.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
differential/
engine/
63 lines
view/
2 lines
view/
formation/
10 lines
4 lines
17 lines
phui/
31 lines
webroot/
rsrc/
css/
application/
diff/
47 lines
phui/
40 lines
js/
application/
diff/
7 lines
23 lines
92 lines
26 lines
core/
24 lines
phuix/
9 lines

Diff 50362

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/engine/DifferentialFileTreeEngine.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetDetailView.php

Loading...
View Options

src/view/formation/PHUIFormationColumnDynamicView.php

Loading...
View Options

src/view/formation/PHUIFormationColumnView.php

Loading...
View Options

src/view/formation/PHUIFormationView.php

Loading...
View Options

src/view/phui/PHUIListItemView.php

Loading...
View Options

webroot/rsrc/css/application/diff/diff-tree-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-formation-view.css

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffPathView.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffTreeView.js

Loading...
View Options

webroot/rsrc/js/core/KeyboardShortcutManager.js

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXFormationColumnView.js

Loading...
Phabricator · Built by Phacility