Page MenuHomePhabricator
Differential D21152

Generate file trees from changesets in the new flank UI
ClosedPublic
Actions

Authored by epriestley on Apr 21 2020, 6:54 PM.
Tags
None
Referenced Files
F13225145: D21152.id.diff
Sun, May 19, 1:40 PM
F13222493: D21152.diff
Sun, May 19, 3:42 AM
F13205131: D21152.diff
Wed, May 15, 1:28 AM
F13188468: D21152.diff
Sat, May 11, 5:16 AM
F13175279: D21152.diff
Wed, May 8, 4:25 AM
Unknown Object (File)
Tue, May 7, 8:30 AM
Unknown Object (File)
Fri, May 3, 8:28 AM
Unknown Object (File)
Thu, May 2, 7:09 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13516: Remove the "filetree" setting (so it's always enabled for everyone)
Commits
rP8cd1f9a30976: Generate file trees from changesets in the new flank UI
Summary

Ref T13516. Generate a tree structure based on the page changesets. Still missing styles and a whole lot of behavior.

Test Plan

Screen Shot 2020-04-21 at 11.49.14 AM.png (1×1 px, 394 KB)

Diff Detail

Repository
rP Phabricator
Branch
flank3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24179
Build 33302: Run Core Tests
Build 33301: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 21 2020, 6:54 PM
Harbormaster completed remote builds in B24179: Diff 50361.Apr 21 2020, 6:55 PM
epriestley requested review of this revision.Apr 21 2020, 6:55 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2020, 3:31 PM
Closed by commit rP8cd1f9a30976: Generate file trees from changesets in the new flank UI (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP8cd1f9a30976: Generate file trees from changesets in the new flank UI.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
differential/
view/
5 lines
webroot/
rsrc/
js/
application/
diff/
19 lines
65 lines
83 lines
159 lines

Diff 50361

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetDetailView.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffPathView.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffTreeView.js

Loading...
Phabricator · Built by Phacility