Page MenuHomePhabricator
Differential D21147

Add "short name", "id", and "phid" variables for external editor URIs
ClosedPublic
Actions

Authored by epriestley on Apr 19 2020, 2:09 PM.
Tags
None
Referenced Files
F14415151: D21147.diff
Tue, Dec 24, 5:14 PM
Unknown Object (File)
Sun, Dec 22, 4:28 AM
Unknown Object (File)
Mon, Dec 16, 4:52 AM
Unknown Object (File)
Tue, Dec 10, 8:57 AM
Unknown Object (File)
Mon, Dec 9, 5:24 AM
Unknown Object (File)
Sun, Dec 8, 2:43 AM
Unknown Object (File)
Thu, Nov 28, 2:47 AM
Unknown Object (File)
Nov 24 2024, 12:27 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13515: Differential: Inlines and View Options
Commits
rPf02024615ad3: Add "short name", "id", and "phid" variables for external editor URIs
Summary

Ref T13515. External editor URIs currently depend on repositories having callsigns, but callsigns are no longer required. Add some variables to support configuring this feature for repositories that do not have callsigns.

Test Plan

Changed settings to use new variables, saw links generate appropriately.

Diff Detail

Repository
rP Phabricator
Branch
sticky10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24163
Build 33281: Run Core Tests
Build 33280: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 50345.Apr 19 2020, 2:09 PM
epriestley created this revision.
  • Documentation tweaks.
Harbormaster completed remote builds in B24162: Diff 50344.Apr 19 2020, 2:10 PM
Harbormaster completed remote builds in B24163: Diff 50345.
epriestley requested review of this revision.Apr 19 2020, 2:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2020, 4:37 PM
Closed by commit rPf02024615ad3: Add "short name", "id", and "phid" variables for external editor URIs (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPf02024615ad3: Add "short name", "id", and "phid" variables for external editor URIs.

Revision Contents
Changeset List

PathSize
src/
applications/
settings/
setting/
4 lines
docs/
user/
userguide/
60 lines
infrastructure/
editor/
31 lines

Diff 50345

View Options

src/applications/settings/setting/PhabricatorEditorSetting.php

Loading...
View Options

src/docs/user/userguide/external_editor.diviner

Loading...
View Options

src/infrastructure/editor/PhabricatorEditorURIEngine.php

Loading...
Phabricator · Built by Phacility