Differential D21146

Add static errors, supported protocols, and a dynamic function listing to external editor settings page
ClosedPublic
Actions

Authored by epriestley on Apr 18 2020, 11:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 23, 2:00 AM

	Unknown Object (File)
	Wed, Jan 22, 3:11 PM

	Unknown Object (File)
	Tue, Jan 21, 9:28 AM

	Unknown Object (File)
	Sun, Jan 5, 2:38 PM

	Unknown Object (File)
	Sun, Jan 5, 4:39 AM

	Unknown Object (File)
	Thu, Jan 2, 3:28 AM

	Unknown Object (File)
	Dec 17 2024, 9:50 AM

	Unknown Object (File)
	Dec 14 2024, 12:47 AM

View All 100 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13515: Differential: Inlines and View Options
Commits: rPc79094d7a8bd: Add static errors, supported protocols, and a dynamic function listing to…

Summary

Previously valid editor URIs may become invalid without being changed (if an administrator removes a protocol from the list, for example), but this isn't explained very well. Show an error on the settings page if the current value isn't usable.
Generate a list of functions from an authority in the parser.
Generate a list of protocols from configuration.

Test Plan

Screen Shot 2020-04-18 at 4.11.15 PM.png (1×1 px, 431 KB)

Diff Detail

Repository

Branch

sticky9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24161
Build 33277: Run Core Tests
Build 33276: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 18 2020, 11:11 PM

Harbormaster completed remote builds in B24161: Diff 50343.Apr 18 2020, 11:13 PM

epriestley requested review of this revision.Apr 18 2020, 11:13 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2020, 4:37 PM

Closed by commit rPc79094d7a8bd: Add static errors, supported protocols, and a dynamic function listing to… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPc79094d7a8bd: Add static errors, supported protocols, and a dynamic function listing to….

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

editor/

PhabricatorSettingsEditEngine.php

30 lines

panel/

PhabricatorEditEngineSettingsPanel.php

11 lines

PhabricatorExternalEditorSettingsPanel.php

146 lines

setting/

PhabricatorEditorSetting.php

23 lines

docs/

user/

userguide/

external_editor.diviner

24 lines

infrastructure/

editor/

PhabricatorEditorURIEngine.php

4 lines

Diff 50343

src/applications/settings/editor/PhabricatorSettingsEditEngine.php

Loading...

src/applications/settings/panel/PhabricatorEditEngineSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php

Loading...

src/applications/settings/setting/PhabricatorEditorSetting.php

Loading...

src/docs/user/userguide/external_editor.diviner

Loading...

src/infrastructure/editor/PhabricatorEditorURIEngine.php

Loading...