Page MenuHomePhabricator

Add static errors, supported protocols, and a dynamic function listing to external editor settings page
ClosedPublic

Authored by epriestley on Apr 18 2020, 11:11 PM.
Tags
None
Referenced Files
F15471579: D21146.diff
Sat, Apr 5, 6:06 AM
F15451041: D21146.id50343.diff
Fri, Mar 28, 7:49 PM
F15450776: D21146.id50355.diff
Fri, Mar 28, 6:11 PM
F15442216: D21146.id.diff
Wed, Mar 26, 10:12 PM
F15435322: D21146.diff
Tue, Mar 25, 7:48 AM
F15428500: D21146.id.diff
Sun, Mar 23, 8:49 PM
F15421337: D21146.diff
Fri, Mar 21, 10:45 PM
F15350651: D21146.diff
Mon, Mar 10, 3:23 PM
Subscribers
None

Details

Summary

Ref T13515.

  • Previously valid editor URIs may become invalid without being changed (if an administrator removes a protocol from the list, for example), but this isn't explained very well. Show an error on the settings page if the current value isn't usable.
  • Generate a list of functions from an authority in the parser.
  • Generate a list of protocols from configuration.
Test Plan

Screen Shot 2020-04-18 at 4.11.15 PM.png (1×1 px, 431 KB)

Diff Detail

Repository
rP Phabricator
Branch
sticky9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24161
Build 33277: Run Core Tests
Build 33276: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2020, 4:37 PM
This revision was automatically updated to reflect the committed changes.