Page MenuHomePhabricator
Differential D21134

When Owners packages are archived, annotate them in tokenizer results
ClosedPublic
Actions

Authored by epriestley on Apr 17 2020, 1:13 PM.
Tags
None
Referenced Files
F15467221: D21134.id50328.diff
Thu, Apr 3, 1:47 PM
F15464664: D21134.id50329.diff
Wed, Apr 2, 12:05 PM
F15463452: D21134.id50328.diff
Tue, Apr 1, 11:38 PM
F15460227: D21134.id.diff
Mon, Mar 31, 9:08 PM
F15457800: D21134.diff
Sun, Mar 30, 7:04 PM
F15456433: D21134.diff
Sun, Mar 30, 9:40 AM
F15442435: D21134.id50328.diff
Wed, Mar 26, 11:25 PM
F15419164: D21134.id50328.diff
Fri, Mar 21, 4:09 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13512: Owners Packages are missing "closed" state in tokenizers
Commits
rP83eb7447a196: When Owners packages are archived, annotate them in tokenizer results
Summary

Fixes T13512. Archived packages in Owners are missing hinting, but should have it.

Test Plan

Before:

Screen Shot 2020-04-17 at 6.08.07 AM.png (120×391 px, 17 KB)

After:

Screen Shot 2020-04-17 at 6.11.27 AM.png (143×469 px, 21 KB)

Diff Detail

Repository
rP Phabricator
Branch
package1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24146
Build 33250: Run Core Tests
Build 33249: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 17 2020, 1:13 PM
Harbormaster completed remote builds in B24146: Diff 50328.Apr 17 2020, 1:14 PM
epriestley requested review of this revision.Apr 17 2020, 1:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 17 2020, 1:18 PM
Closed by commit rP83eb7447a196: When Owners packages are archived, annotate them in tokenizer results (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP83eb7447a196: When Owners packages are archived, annotate them in tokenizer results.

Revision Contents
Changeset List

PathSize
src/
applications/
owners/
typeahead/
8 lines

Diff 50328

View Options

src/applications/owners/typeahead/PhabricatorOwnersPackageDatasource.php

Loading...
Phabricator · Built by Phacility