When Owners packages are archived, annotate them in tokenizer results
ClosedPublic
Actions

Authored by epriestley on Apr 17 2020, 1:13 PM.

Tags

None

Referenced Files

	F14090845: D21134.diff
	Sun, Nov 24, 8:45 PM

	Unknown Object (File)
	Fri, Nov 22, 8:22 AM

	Unknown Object (File)
	Thu, Nov 21, 7:40 AM

	Unknown Object (File)
	Sun, Nov 17, 1:16 AM

	Unknown Object (File)
	Oct 26 2024, 12:39 AM

	Unknown Object (File)
	Oct 22 2024, 5:11 AM

	Unknown Object (File)
	Oct 9 2024, 1:22 PM

	Unknown Object (File)
	Oct 1 2024, 8:05 PM

View All 99 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13512: Owners Packages are missing "closed" state in tokenizers
Commits: rP83eb7447a196: When Owners packages are archived, annotate them in tokenizer results

Summary

Fixes T13512. Archived packages in Owners are missing hinting, but should have it.

Test Plan

Before:

Screen Shot 2020-04-17 at 6.08.07 AM.png (120×391 px, 17 KB)

After:

Screen Shot 2020-04-17 at 6.11.27 AM.png (143×469 px, 21 KB)

Diff Detail

Repository

rP Phabricator

Branch

package1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24146
Build 33250: Run Core Tests
Build 33249: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 17 2020, 1:13 PM

Harbormaster completed remote builds in B24146: Diff 50328.Apr 17 2020, 1:14 PM

epriestley requested review of this revision.Apr 17 2020, 1:14 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 17 2020, 1:18 PM

Closed by commit rP83eb7447a196: When Owners packages are archived, annotate them in tokenizer results (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP83eb7447a196: When Owners packages are archived, annotate them in tokenizer results.

Revision Contents
Changeset List

Path

Size

src/

applications/

owners/

typeahead/

PhabricatorOwnersPackageDatasource.php

8 lines

Diff 50328

View Options

src/applications/owners/typeahead/PhabricatorOwnersPackageDatasource.php

When Owners packages are archived, annotate them in tokenizer resultsClosedPublicActions