Disable automatic decoding of "Content-Encoding" responses during "Accept-Encoding" setup test
ClosedPublic
Actions

Authored by epriestley on Apr 15 2020, 12:28 PM.

Details

Reviewers: None
Maniphest Tasks: T13507: Compress Conduit client requests
Commits: rPb52fa9623837: Disable automatic decoding of "Content-Encoding" responses during "Accept…

Summary

Ref T13507. Now that we handle processing of "Content-Encoding: gzip" headers by default, this setup check can get a decompressed body back. Since it specifically wants a raw body back, disable this behavior.

Also, "@" a couple things which can get in the way if they fail now that error handling is more aggressive about throwing on warnings.

Test Plan

Ran setup check after other changes in T13507, got clean result.

Diff Detail

Repository

rP Phabricator

Branch

notification1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24119
Build 33210: Run Core Tests
Build 33209: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 15 2020, 12:28 PM

Harbormaster completed remote builds in B24119: Diff 50301.Apr 15 2020, 12:29 PM

epriestley requested review of this revision.Apr 15 2020, 12:29 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 15 2020, 1:28 PM

Closed by commit rPb52fa9623837: Disable automatic decoding of "Content-Encoding" responses during "Accept… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPb52fa9623837: Disable automatic decoding of "Content-Encoding" responses during "Accept….

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorWebServerSetupCheck.php

5 lines

Diff 50301

View Options

src/applications/config/check/PhabricatorWebServerSetupCheck.php

Disable automatic decoding of "Content-Encoding" responses during "Accept-Encoding" setup testClosedPublicActions