Page MenuHomePhabricator

Provide a "--local" flag to "bin/conduit call" to force in-process execution
ClosedPublic

Authored by epriestley on Apr 14 2020, 7:51 PM.
Tags
None
Referenced Files
F15310259: D21114.id50285.diff
Thu, Mar 6, 8:18 AM
Unknown Object (File)
Mon, Mar 3, 8:15 AM
Unknown Object (File)
Sun, Mar 2, 11:30 PM
Unknown Object (File)
Sun, Mar 2, 1:36 PM
Unknown Object (File)
Fri, Feb 28, 1:36 AM
Unknown Object (File)
Wed, Feb 26, 11:04 PM
Unknown Object (File)
Feb 18 2025, 4:40 AM
Unknown Object (File)
Feb 16 2025, 5:38 PM
Subscribers
None

Details

Summary

See PHI1692. Currently, it's hard to get a local profile or "--trace" of some Diffusion API methods, since they always proxy via HTTP -- even if the local node can serve the request.

This always-proxy behavior is intentional (so we always go down the same code path, to limit surprises) but inconvenient when debugging. Allow an operator to connect to a node which can serve a request and issue a --local call to force in-process execution.

This makes it straightforward to "--trace" or "--xprofile" the call.

Test Plan

Ran bin/conduit call ... with and without --local using a Diffusion method on a clustered repository. Without --local, saw proxy via HTTP. With --local, saw in-process execution.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2020, 8:24 PM
This revision was automatically updated to reflect the committed changes.