Page MenuHomePhabricator

Provide a "--local" flag to "bin/conduit call" to force in-process execution
ClosedPublic

Authored by epriestley on Apr 14 2020, 7:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 2:45 AM
Unknown Object (File)
Tue, Nov 19, 3:16 AM
Unknown Object (File)
Fri, Nov 15, 6:44 PM
Unknown Object (File)
Tue, Nov 12, 2:22 PM
Unknown Object (File)
Mon, Oct 28, 1:53 PM
Unknown Object (File)
Oct 18 2024, 10:11 PM
Unknown Object (File)
Oct 17 2024, 6:52 PM
Unknown Object (File)
Sep 17 2024, 3:30 AM
Subscribers
None

Details

Summary

See PHI1692. Currently, it's hard to get a local profile or "--trace" of some Diffusion API methods, since they always proxy via HTTP -- even if the local node can serve the request.

This always-proxy behavior is intentional (so we always go down the same code path, to limit surprises) but inconvenient when debugging. Allow an operator to connect to a node which can serve a request and issue a --local call to force in-process execution.

This makes it straightforward to "--trace" or "--xprofile" the call.

Test Plan

Ran bin/conduit call ... with and without --local using a Diffusion method on a clustered repository. Without --local, saw proxy via HTTP. With --local, saw in-process execution.

Diff Detail

Repository
rP Phabricator
Branch
conduit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24103
Build 33186: Run Core Tests
Build 33185: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2020, 8:24 PM
This revision was automatically updated to reflect the committed changes.