Add "uri" to the fields returned by "differential.revision.search"
ClosedPublic
Actions

Authored by epriestley on Apr 13 2020, 7:00 PM.

Details

Reviewers: None
Maniphest Tasks: T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits: rP5597f4e6f229: Add "uri" to the fields returned by "differential.revision.search"

Summary

Ref T13490. This simplifies mostly-theoretical cases where you're accessing Phabricator via arc-over-ssh and the Conduit protocol + domain may differ from the production protocol + domain.

Test Plan

Called API via web UI, saw sensible URI values in results.

Diff Detail

Repository

rP Phabricator

Branch

uri1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24079
Build 33150: Run Core Tests
Build 33149: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 13 2020, 7:00 PM

Harbormaster completed remote builds in B24079: Diff 50261.Apr 13 2020, 7:01 PM

epriestley requested review of this revision.Apr 13 2020, 7:01 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 13 2020, 7:06 PM

Closed by commit rP5597f4e6f229: Add "uri" to the fields returned by "differential.revision.search" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP5597f4e6f229: Add "uri" to the fields returned by "differential.revision.search".

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialRevision.php

1 line

Diff 50261

View Options

src/applications/differential/storage/DifferentialRevision.php

Add "uri" to the fields returned by "differential.revision.search"ClosedPublicActions