Paths

Table of Contentst

Restore "arc alias" shell aliases
ClosedPublic
Actions

Authored by epriestley on Apr 11 2020, 4:54 PM.

Tags

None

Referenced Files

	F14799178: D21084.id50225.diff
	Sat, Jan 25, 6:57 AM

	F14799177: D21084.id50224.diff
	Sat, Jan 25, 6:57 AM

	F14799176: D21084.id.diff
	Sat, Jan 25, 6:57 AM

	F14799175: D21084.diff
	Sat, Jan 25, 6:57 AM

	Unknown Object (File)
	Tue, Jan 21, 8:20 PM

	Unknown Object (File)
	Tue, Jan 21, 3:37 PM

	Unknown Object (File)
	Tue, Jan 21, 10:32 AM

	Unknown Object (File)
	Mon, Jan 20, 9:48 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rARC387027eb3a72: Restore "arc alias" shell aliases

Summary

See https://discourse.phabricator-community.org/t/exception-when-trying-to-run-an-arc-alias-undefined-method-arcanistalias-getshellcommand/3731/.

Shell aliases got lost in the shuffle of porting "arc alias"; restore them.

Test Plan

Bound arc ls to ls -alh, ran arc ls.

Diff Detail

Repository

rARC Arcanist

Branch

shell1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24042
Build 33094: Run Core Tests
Build 33093: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 11 2020, 4:54 PM

Harbormaster completed remote builds in B24042: Diff 50224.Apr 11 2020, 4:55 PM

epriestley requested review of this revision.Apr 11 2020, 4:55 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2020, 4:59 PM

Closed by commit rARC387027eb3a72: Restore "arc alias" shell aliases (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC387027eb3a72: Restore "arc alias" shell aliases.

Revision Contents
Changeset List

Path

Size

src/

runtime/

ArcanistRuntime.php

17 lines

toolset/

ArcanistAliasEngine.php

21 lines

Diff 50224

View Options

src/runtime/ArcanistRuntime.php