Differential D21082

Reroute all RefQuery callers to HardpointEngine
ClosedPublic
Actions

Authored by epriestley on Apr 11 2020, 1:40 PM.

Tags

None

Referenced Files

	F15425129: D21082.id50222.diff
	Sun, Mar 23, 2:35 AM

	F15413863: D21082.diff
	Wed, Mar 19, 9:46 PM

	F15413459: D21082.diff
	Wed, Mar 19, 6:54 PM

	Unknown Object (File)
	Sun, Mar 2, 12:07 PM

	Unknown Object (File)
	Feb 25 2025, 6:25 PM

	Unknown Object (File)
	Feb 15 2025, 1:28 AM

	Unknown Object (File)
	Feb 9 2025, 8:53 AM

	Unknown Object (File)
	Feb 9 2025, 8:53 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T11968: Decide the fate of FutureGraph
Commits: rARCdc42f51cf70c: Reroute all RefQuery callers to HardpointEngine

Summary

Ref T11968. "arc browse", "arc branch", and "arc diff" currently may execute into the RefQuery engine. Reroute them to the HardpointEngine.

This removes older-generation "Ref" objects and renames the replacement "RefPro" objects to "Ref".

Test Plan

Ran "arc branch", "arc browse <various things>", "arc diff", searched for affected symbols.

Diff Detail

Repository

Branch

hpx5

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/browse/workflow/ArcanistBrowseWorkflow.php:110	XHP16	TODO Comment
Advice	src/browse/workflow/ArcanistBrowseWorkflow.php:114	XHP16	TODO Comment
Advice	src/browse/workflow/ArcanistBrowseWorkflow.php:117	XHP16	TODO Comment
Advice	src/ref/ArcanistWorkingCopyStateRef.php:23	XHP16	TODO Comment
Advice	src/workflow/ArcanistDiffWorkflow.php:3054	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 24038
Build 33088: Run Core Tests
Build 33087: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 11 2020, 1:40 PM

Harbormaster completed remote builds in B24038: Diff 50220.Apr 11 2020, 1:41 PM

epriestley requested review of this revision.Apr 11 2020, 1:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2020, 1:46 PM

Closed by commit rARCdc42f51cf70c: Reroute all RefQuery callers to HardpointEngine (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCdc42f51cf70c: Reroute all RefQuery callers to HardpointEngine.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

browse/

loader/

ArcanistBrowseURIHardpointLoader.php

4 lines

query/

ArcanistBrowseCommitHardpointQuery.php

8 lines

ArcanistBrowseCommitURIHardpointQuery.php

31 lines

ArcanistBrowsePathURIHardpointQuery.php

54 lines

ArcanistBrowseRevisionURIHardpointQuery.php

4 lines

ArcanistBrowseURIHardpointQuery.php

8 lines

ref/

ArcanistBrowseRef.php

23 lines

ArcanistBrowseRefPro.php

ArcanistBrowseURIRef.php

2 lines

ArcanistBrowseURIRefPro.php

workflow/

ArcanistBrowseWorkflow.php

31 lines

inspector/

ArcanistBrowseRefInspector.php

2 lines

ArcanistCommitRefInspector.php

2 lines

ArcanistWorkingCopyStateRefInspector.php

4 lines

query/

ArcanistCommitUpstreamHardpointQuery.php

6 lines

ArcanistGitCommitMessageHardpointQuery.php

6 lines

ArcanistGitWorkingCopyRevisionHardpointQuery.php

10 lines

ArcanistMessageRevisionHardpointQuery.php

12 lines

ArcanistWorkingCopyCommitHardpointQuery.php

10 lines

ref/

ArcanistBranchRef.php

14 lines

ArcanistBranchRefPro.php

ArcanistCommitRef.php

23 lines

ArcanistCommitRefPro.php

ArcanistRef.php

102 lines

ArcanistRefPro.php

ArcanistRepositoryRef.php

2 lines

ArcanistRevisionRef.php

6 lines

ArcanistRevisionRefPro.php

ArcanistWorkingCopyStateRef.php

90 lines

ArcanistWorkingCopyStateRefPro.php

toolset/

query/

ArcanistWorkflowHardpointQuery.php

6 lines

workflow/

ArcanistDiffWorkflow.php

19 lines

ArcanistFeatureWorkflow.php

28 lines

ArcanistInspectWorkflow.php

8 lines

ArcanistWorkflow.php

9 lines

Diff 50220

src/__phutil_library_map__.php

Loading...

src/browse/loader/ArcanistBrowseURIHardpointLoader.php

Loading...

src/browse/query/ArcanistBrowseCommitHardpointQuery.php

Loading...

src/browse/query/ArcanistBrowseCommitURIHardpointQuery.php

Loading...

src/browse/query/ArcanistBrowsePathURIHardpointQuery.php

Loading...

src/browse/query/ArcanistBrowseRevisionURIHardpointQuery.php

Loading...

src/browse/query/ArcanistBrowseURIHardpointQuery.php

Loading...

src/browse/ref/ArcanistBrowseRef.php

Loading...

src/browse/ref/ArcanistBrowseRefPro.php

Loading...

src/browse/ref/ArcanistBrowseURIRef.php

Loading...

src/browse/ref/ArcanistBrowseURIRefPro.php

Loading...

src/browse/workflow/ArcanistBrowseWorkflow.php

Loading...

src/inspector/ArcanistBrowseRefInspector.php

Loading...

src/inspector/ArcanistCommitRefInspector.php

Loading...

src/inspector/ArcanistWorkingCopyStateRefInspector.php

Loading...

src/query/ArcanistCommitUpstreamHardpointQuery.php

Loading...

src/query/ArcanistGitCommitMessageHardpointQuery.php

Loading...

src/query/ArcanistGitWorkingCopyRevisionHardpointQuery.php

Loading...

src/query/ArcanistMessageRevisionHardpointQuery.php

Loading...

src/query/ArcanistWorkingCopyCommitHardpointQuery.php

Loading...

src/ref/ArcanistBranchRef.php

Loading...

src/ref/ArcanistBranchRefPro.php

Loading...

src/ref/ArcanistCommitRef.php

Loading...

src/ref/ArcanistCommitRefPro.php

Loading...

src/ref/ArcanistRef.php

Loading...

src/ref/ArcanistRefPro.php

Loading...

src/ref/ArcanistRepositoryRef.php

Loading...

src/ref/ArcanistRevisionRef.php

Loading...

src/ref/ArcanistRevisionRefPro.php

Loading...

src/ref/ArcanistWorkingCopyStateRef.php

Loading...

src/ref/ArcanistWorkingCopyStateRefPro.php

Loading...

src/toolset/query/ArcanistWorkflowHardpointQuery.php

Loading...

src/workflow/ArcanistDiffWorkflow.php

Loading...

src/workflow/ArcanistFeatureWorkflow.php

Loading...

src/workflow/ArcanistInspectWorkflow.php

Loading...

src/workflow/ArcanistWorkflow.php

Loading...