Differential D21078

Introduce "arc inspect" and some of the new ref/hardpoint classes
ClosedPublic
Actions

Authored by epriestley on Apr 10 2020, 11:39 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 14, 12:03 AM

	Unknown Object (File)
	Fri, Nov 1, 8:37 PM

	Unknown Object (File)
	Thu, Oct 31, 4:45 AM

	Unknown Object (File)
	Wed, Oct 23, 4:17 PM

	Unknown Object (File)
	Wed, Oct 23, 3:25 PM

	Unknown Object (File)
	Wed, Oct 23, 3:03 PM

	Unknown Object (File)
	Wed, Oct 23, 3:02 PM

	Unknown Object (File)
	Wed, Oct 23, 2:58 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T11968: Decide the fate of FutureGraph
Commits: rARCadea2550f533: Introduce "arc inspect" and some of the new ref/hardpoint classes

Summary

Ref T11968. Inches toward the new ref/hardpoint code by introducing the modern refs as "RefPro" objects and supporting an "arc inspect <object>" to load objects and hardpoints.

This doesn't impact any existing runtime behavior.

Test Plan

Ran "arc inspect [--all] commit(...)", got hardpoint queries and yield-based data fetching.

Diff Detail

Repository

Branch

hpx3

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/query/ArcanistGitCommitMessageHardpointQuery.php:27	XHP16	TODO Comment
Advice	src/ref/ArcanistWorkingCopyStateRefPro.php:11	XHP16	TODO Comment
Advice	src/toolset/query/ArcanistWorkflowHardpointQuery.php:67	XHP16	TODO Comment
Advice	src/workflow/ArcanistWorkflow.php:2344	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 24030
Build 33076: Run Core Tests
Build 33075: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 10 2020, 11:39 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 10 2020, 11:40 AM

Harbormaster failed remote builds in B24029: Diff 50211!

Don't "return $value" inside generators, since this does not work until PHP7.

Harbormaster completed remote builds in B24030: Diff 50212.Apr 10 2020, 11:58 AM

epriestley requested review of this revision.Apr 10 2020, 11:58 AM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2020, 12:01 PM

Closed by commit rARCadea2550f533: Introduce "arc inspect" and some of the new ref/hardpoint classes (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCadea2550f533: Introduce "arc inspect" and some of the new ref/hardpoint classes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

hardpoint/

ArcanistHardpointList.php

4 lines

ArcanistHardpointTask.php

25 lines

ArcanistHardpointTaskResult.php

16 lines

inspector/

ArcanistCommitRefInspector.php

22 lines

ArcanistRefInspector.php

16 lines

query/

ArcanistCommitUpstreamHardpointQuery.php

53 lines

ArcanistGitCommitMessageHardpointQuery.php

53 lines

ArcanistWorkingCopyCommitHardpointQuery.php

39 lines

ref/

ArcanistBranchRefPro.php

57 lines

ArcanistCommitRefPro.php

93 lines

ArcanistRefPro.php

8 lines

ArcanistWorkingCopyStateRefPro.php

62 lines

repository/

api/

ArcanistFilesystemAPI.php

6 lines

toolset/

query/

ArcanistWorkflowHardpointQuery.php

88 lines

workflow/

ArcanistInspectWorkflow.php

207 lines

ArcanistWorkflow.php

38 lines

workingcopy/

ArcanistFilesystemWorkingCopy.php

2 lines

ArcanistWorkingCopy.php

2 lines

Diff 50212

src/__phutil_library_map__.php

Loading...

src/hardpoint/ArcanistHardpointList.php

Loading...

src/hardpoint/ArcanistHardpointTask.php

Loading...

src/hardpoint/ArcanistHardpointTaskResult.php

Loading...

src/inspector/ArcanistCommitRefInspector.php

Loading...

src/inspector/ArcanistRefInspector.php

Loading...

src/query/ArcanistCommitUpstreamHardpointQuery.php

Loading...

src/query/ArcanistGitCommitMessageHardpointQuery.php

Loading...

src/query/ArcanistWorkingCopyCommitHardpointQuery.php

Loading...

src/ref/ArcanistBranchRefPro.php

Loading...

src/ref/ArcanistCommitRefPro.php

Loading...

src/ref/ArcanistRefPro.php

Loading...

src/ref/ArcanistWorkingCopyStateRefPro.php

Loading...

src/repository/api/ArcanistFilesystemAPI.php

Loading...

src/toolset/query/ArcanistWorkflowHardpointQuery.php

Loading...

src/workflow/ArcanistInspectWorkflow.php

Loading...

src/workflow/ArcanistWorkflow.php

Loading...

src/workingcopy/ArcanistFilesystemWorkingCopy.php

Loading...

src/workingcopy/ArcanistWorkingCopy.php

Loading...