Page MenuHomePhabricator

Introduce "arc inspect" and some of the new ref/hardpoint classes
ClosedPublic

Authored by epriestley on Apr 10 2020, 11:39 AM.
Tags
None
Referenced Files
F15400771: D21078.id50213.diff
Mon, Mar 17, 1:56 PM
F15392802: D21078.diff
Sat, Mar 15, 5:39 PM
F15377044: D21078.id.diff
Thu, Mar 13, 7:31 AM
Unknown Object (File)
Fri, Feb 21, 5:39 AM
Unknown Object (File)
Wed, Feb 19, 12:52 AM
Unknown Object (File)
Feb 15 2025, 1:01 AM
Unknown Object (File)
Feb 12 2025, 12:07 AM
Unknown Object (File)
Feb 9 2025, 8:52 AM
Subscribers
None

Details

Summary

Ref T11968. Inches toward the new ref/hardpoint code by introducing the modern refs as "RefPro" objects and supporting an "arc inspect <object>" to load objects and hardpoints.

This doesn't impact any existing runtime behavior.

Test Plan

Ran "arc inspect [--all] commit(...)", got hardpoint queries and yield-based data fetching.

Diff Detail

Repository
rARC Arcanist
Branch
hpx3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24030
Build 33076: Run Core Tests
Build 33075: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 10 2020, 11:40 AM
Harbormaster failed remote builds in B24029: Diff 50211!
  • Don't "return $value" inside generators, since this does not work until PHP7.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2020, 12:01 PM
This revision was automatically updated to reflect the committed changes.