Page MenuHomePhabricator

Introduce "arc inspect" and some of the new ref/hardpoint classes
ClosedPublic

Authored by epriestley on Apr 10 2020, 11:39 AM.
Tags
None
Referenced Files
F15472149: D21078.diff
Sat, Apr 5, 11:07 AM
F15458655: D21078.id50212.diff
Mon, Mar 31, 6:02 AM
F15457062: D21078.diff
Sun, Mar 30, 2:05 PM
F15451961: D21078.id50213.diff
Sat, Mar 29, 12:54 AM
F15427238: D21078.id50213.diff
Sun, Mar 23, 1:24 PM
F15417694: D21078.id50212.diff
Thu, Mar 20, 5:55 PM
F15409912: D21078.id50211.diff
Wed, Mar 19, 5:54 AM
F15400771: D21078.id50213.diff
Mon, Mar 17, 1:56 PM
Subscribers
None

Details

Summary

Ref T11968. Inches toward the new ref/hardpoint code by introducing the modern refs as "RefPro" objects and supporting an "arc inspect <object>" to load objects and hardpoints.

This doesn't impact any existing runtime behavior.

Test Plan

Ran "arc inspect [--all] commit(...)", got hardpoint queries and yield-based data fetching.

Diff Detail

Repository
rARC Arcanist
Branch
hpx3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24030
Build 33076: Run Core Tests
Build 33075: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 10 2020, 11:40 AM
Harbormaster failed remote builds in B24029: Diff 50211!
  • Don't "return $value" inside generators, since this does not work until PHP7.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2020, 12:01 PM
This revision was automatically updated to reflect the committed changes.