Page MenuHomePhabricator

Introduce "arc inspect" and some of the new ref/hardpoint classes
ClosedPublic

Authored by epriestley on Apr 10 2020, 11:39 AM.
Tags
None
Referenced Files
F18780731: D21078.id50212.diff
Sun, Oct 12, 7:16 PM
F18768118: D21078.id50212.diff
Wed, Oct 8, 1:50 AM
F18757038: D21078.id50213.diff
Sun, Oct 5, 3:15 PM
F18734198: D21078.id.diff
Tue, Sep 30, 10:49 PM
F18567732: D21078.id.diff
Sep 9 2025, 4:08 PM
F18399258: D21078.id50211.diff
Aug 29 2025, 4:04 PM
F18379199: D21078.id50213.diff
Aug 28 2025, 3:25 PM
F18370994: D21078.diff
Aug 28 2025, 4:29 AM
Subscribers
None

Details

Summary

Ref T11968. Inches toward the new ref/hardpoint code by introducing the modern refs as "RefPro" objects and supporting an "arc inspect <object>" to load objects and hardpoints.

This doesn't impact any existing runtime behavior.

Test Plan

Ran "arc inspect [--all] commit(...)", got hardpoint queries and yield-based data fetching.

Diff Detail

Repository
rARC Arcanist
Branch
hpx3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24029
Build 33074: Run Core Tests
Build 33073: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 10 2020, 11:40 AM
Harbormaster failed remote builds in B24029: Diff 50211!
  • Don't "return $value" inside generators, since this does not work until PHP7.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2020, 12:01 PM
This revision was automatically updated to reflect the committed changes.