Refine handling of "@task" attributes in Diviner
ClosedPublic
Actions

Authored by epriestley on Apr 6 2020, 6:49 PM.

Details

Reviewers: None
Maniphest Tasks: T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given"
Commits: rP58fbf64a2786: Refine handling of "@task" attributes in Diviner

Summary

Ref T13505. See that task for details. When a class has exactly one "@task" block, this API returns a string. Some day, this should be made more consistent.

Test Plan

Viewed a class with exactly one "@task", no more fatal. Viewed classes with zero and more than one "@task" attributes, got clean renderings.

Diff Detail

Repository

rP Phabricator

Branch

diviner2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23999
Build 33029: Run Core Tests
Build 33028: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 6 2020, 6:49 PM

Harbormaster completed remote builds in B23999: Diff 50180.Apr 6 2020, 6:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 6 2020, 6:51 PM

epriestley requested review of this revision.

Closed by commit rP58fbf64a2786: Refine handling of "@task" attributes in Diviner (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP58fbf64a2786: Refine handling of "@task" attributes in Diviner.

epriestley mentioned this in T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".Apr 6 2020, 7:02 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

controller/

DivinerAtomController.php

9 lines

Diff 50180

View Options

src/applications/diviner/controller/DivinerAtomController.php

Refine handling of "@task" attributes in DivinerClosedPublicActions