Page MenuHomePhabricator

Fix error behavior of "arc version" when it encounters a library which is not a working copy
ClosedPublic

Authored by epriestley on Apr 2 2020, 3:20 PM.
Tags
None
Referenced Files
F14799033: D21050.id50151.diff
Sat, Jan 25, 6:50 AM
F14799032: D21050.id50150.diff
Sat, Jan 25, 6:50 AM
F14799031: D21050.id.diff
Sat, Jan 25, 6:50 AM
Unknown Object (File)
Tue, Jan 21, 3:21 PM
Unknown Object (File)
Tue, Jan 21, 9:57 AM
Unknown Object (File)
Mon, Jan 20, 1:42 PM
Unknown Object (File)
Mon, Jan 20, 1:42 PM
Unknown Object (File)
Mon, Jan 20, 1:42 PM
Subscribers
None

Details

Summary

Ref T13504. The API has changed here slightly, and if you run "arc version" without "arcanist/" being a Git working copy, it currently fatals in a misleading way.

Instead, reach the error properly.

Test Plan

Ran "arc version" after moving aside ".git/", got a helpful error message instead of a confusing "call on null" exception.

Diff Detail

Repository
rARC Arcanist
Branch
version1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23969
Build 32985: Run Core Tests
Build 32984: arc lint + arc unit