Fix error behavior of "arc version" when it encounters a library which is not a working copy
ClosedPublic
Actions

Authored by epriestley on Apr 2 2020, 3:20 PM.

Details

Reviewers: None
Maniphest Tasks: T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable
Commits: rARC5ce1d7971746: Fix error behavior of "arc version" when it encounters a library which is not a…

Summary

Ref T13504. The API has changed here slightly, and if you run "arc version" without "arcanist/" being a Git working copy, it currently fatals in a misleading way.

Instead, reach the error properly.

Test Plan

Ran "arc version" after moving aside ".git/", got a helpful error message instead of a confusing "call on null" exception.

Diff Detail

Repository

rARC Arcanist

Branch

version1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23969
Build 32985: Run Core Tests
Build 32984: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 2 2020, 3:20 PM

Harbormaster completed remote builds in B23969: Diff 50150.Apr 2 2020, 3:20 PM

epriestley requested review of this revision.Apr 2 2020, 3:20 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 2 2020, 3:24 PM

Closed by commit rARC5ce1d7971746: Fix error behavior of "arc version" when it encounters a library which is not a… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC5ce1d7971746: Fix error behavior of "arc version" when it encounters a library which is not a….

Revision Contents
Changeset List

Path

Size

src/

toolset/

workflow/

ArcanistVersionWorkflow.php

18 lines

Diff 50150

View Options

src/toolset/workflow/ArcanistVersionWorkflow.php

Fix error behavior of "arc version" when it encounters a library which is not a working copyClosedPublicActions