Page MenuHomePhabricator
Differential D21024

Fix two "implode()" order issues arising from wilds/experimental collapse
ClosedPublic
Actions

Authored by epriestley on Feb 23 2020, 4:33 PM.
Tags
None
Referenced Files
F13256744: D21024.diff
Sat, May 25, 4:44 PM
F13232523: D21024.diff
Tue, May 21, 1:20 AM
F13206997: D21024.id.diff
Wed, May 15, 8:05 PM
F13190882: D21024.id.diff
Sat, May 11, 2:58 PM
F13187355: D21024.diff
Sat, May 11, 4:28 AM
F13184463: D21024.diff
Fri, May 10, 7:00 PM
Unknown Object (File)
Tue, May 7, 7:36 AM
Unknown Object (File)
Fri, May 3, 6:58 AM
View All 68 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits
rARCde461bb1794f: Fix two "implode()" order issues arising from wilds/experimental collapse
Summary

Ref T13490. There's one simple "implode()" order issue here, and one slightly more complex one that uses "DIRECTORY_SEPARATOR" as glue.

Add test coverage for this, update the lint check to detect constants used as glue, and fix the callsites.

Test Plan
  • Added a failing test and made it pass.
  • Ran arc lint --everything and looked for remaining implode warnings, found none.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 23 2020, 4:33 PM
Harbormaster completed remote builds in B23907: Diff 50085.Feb 23 2020, 4:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2020, 4:33 PM
epriestley requested review of this revision.
Closed by commit rARCde461bb1794f: Fix two "implode()" order issues arising from wilds/experimental collapse (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCde461bb1794f: Fix two "implode()" order issues arising from wilds/experimental collapse.

Revision Contents
Changeset List

PathSize
src/
filesystem/
2 lines
lint/
linter/
xhpast/
rules/
12 lines
__tests__/
implode-argument-order/
5 lines
workflow/
2 lines

Diff 50086

View Options

src/filesystem/Filesystem.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistImplodeArgumentOrderXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/implode-argument-order/implode.lint-test

Loading...
View Options

src/workflow/ArcanistCloseWorkflow.php

Loading...
Phabricator · Built by Phacility