Ref T13490. There's one simple "implode()" order issue here, and one slightly more complex one that uses "DIRECTORY_SEPARATOR" as glue.
Add test coverage for this, update the lint check to detect constants used as glue, and fix the callsites.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13490: Upgrade all "classic" Arcanist workflows to Toolsets
- Commits
- rARCde461bb1794f: Fix two "implode()" order issues arising from wilds/experimental collapse
- Added a failing test and made it pass.
- Ran arc lint --everything and looked for remaining implode warnings, found none.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- implode1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 23907 Build 32896: Run Core Tests Build 32895: arc lint + arc unit