Page MenuHomePhabricator
Differential D20997

Port "arc shell-complete" to Toolsets
ClosedPublic
Actions

Authored by epriestley on Feb 14 2020, 5:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 8:43 AM
Unknown Object (File)
Sun, Feb 9, 8:43 AM
Unknown Object (File)
Sun, Feb 9, 8:43 AM
Unknown Object (File)
Tue, Jan 28, 5:28 AM
Unknown Object (File)
Tue, Jan 28, 12:30 AM
Unknown Object (File)
Sat, Jan 25, 6:38 AM
Unknown Object (File)
Sat, Jan 25, 6:38 AM
Unknown Object (File)
Sat, Jan 25, 6:38 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13395: Strip libphutil for parts
Commits
rARC8cd79d38aff2: Port "arc shell-complete" to Toolsets
Summary

Depends on D20996. Ref T13395. Ports the updated version of this workflow from "experimental".

Test Plan

Ran arc shell-complete to install the hook, then shell-completed commands.

Diff Detail

Repository
rARC Arcanist
Branch
flow5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/toolset/workflow/ArcanistShellCompleteWorkflow.php:599XHP16TODO Comment
Advicesrc/toolset/workflow/ArcanistShellCompleteWorkflow.php:602XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 23852
Build 32815: Run Core Tests
Build 32814: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 14 2020, 5:12 PM
Harbormaster completed remote builds in B23852: Diff 50026.Feb 14 2020, 5:13 PM
epriestley requested review of this revision.Feb 14 2020, 5:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 14 2020, 5:16 PM
Closed by commit rARC8cd79d38aff2: Port "arc shell-complete" to Toolsets (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC8cd79d38aff2: Port "arc shell-complete" to Toolsets.

Revision Contents
Changeset List

Diff 50026

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/toolset/workflow/ArcanistShellCompleteWorkflow.php

Loading...
View Options

src/workflow/ArcanistShellCompleteWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility