Page MenuHomePhabricator
Differential D20997

Port "arc shell-complete" to Toolsets
ClosedPublic
Actions

Authored by epriestley on Feb 14 2020, 5:12 PM.
Tags
None
Referenced Files
F13183503: D20997.id.diff
Fri, May 10, 9:43 AM
F13183201: D20997.id50026.diff
Fri, May 10, 7:30 AM
Unknown Object (File)
Tue, May 7, 9:20 AM
Unknown Object (File)
Sat, May 4, 2:27 PM
Unknown Object (File)
Fri, May 3, 6:14 AM
Unknown Object (File)
Sun, Apr 28, 11:29 PM
Unknown Object (File)
Sat, Apr 20, 5:05 PM
Unknown Object (File)
Thu, Apr 18, 4:48 AM
View All 88 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13395: Strip libphutil for parts
Commits
rARC8cd79d38aff2: Port "arc shell-complete" to Toolsets
Summary

Depends on D20996. Ref T13395. Ports the updated version of this workflow from "experimental".

Test Plan

Ran arc shell-complete to install the hook, then shell-completed commands.

Diff Detail

Repository
rARC Arcanist
Branch
flow5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/toolset/workflow/ArcanistShellCompleteWorkflow.php:599XHP16TODO Comment
Advicesrc/toolset/workflow/ArcanistShellCompleteWorkflow.php:602XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 23852
Build 32815: Run Core Tests
Build 32814: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 14 2020, 5:12 PM
Harbormaster completed remote builds in B23852: Diff 50026.Feb 14 2020, 5:13 PM
epriestley requested review of this revision.Feb 14 2020, 5:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 14 2020, 5:16 PM
Closed by commit rARC8cd79d38aff2: Port "arc shell-complete" to Toolsets (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC8cd79d38aff2: Port "arc shell-complete" to Toolsets.

Revision Contents
Changeset List

Diff 50026

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/toolset/workflow/ArcanistShellCompleteWorkflow.php

Loading...
View Options

src/workflow/ArcanistShellCompleteWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility