Page MenuHomePhabricator
Differential D20992

Port "arc liberate" to Toolsets
ClosedPublic
Actions

Authored by epriestley on Feb 13 2020, 10:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 7:43 AM
Unknown Object (File)
Tue, Apr 2, 5:37 AM
Unknown Object (File)
Sun, Mar 31, 4:03 PM
Unknown Object (File)
Thu, Mar 28, 2:18 PM
Unknown Object (File)
Sun, Mar 24, 12:36 PM
Unknown Object (File)
Feb 23 2024, 7:47 PM
Unknown Object (File)
Feb 14 2024, 10:49 PM
Unknown Object (File)
Jan 7 2024, 5:42 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13395: Strip libphutil for parts
Commits
rARCcf9469e0d10b: Port "arc liberate" to Toolsets
Summary

Ref T13395. Depends on D20991. Make "arc liberate" run as a toolset command, not a classic command.

Test Plan

Ran "arc liberate"; created this diff.

Diff Detail

Repository
rARC Arcanist
Branch
flow2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23845
Build 32803: Run Core Tests
Build 32802: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2020, 10:57 PM
epriestley edited the summary of this revision. (Show Details)Feb 13 2020, 10:58 PM
epriestley added a task: T13395: Strip libphutil for parts.
Harbormaster completed remote builds in B23844: Diff 50018.Feb 13 2020, 10:58 PM
epriestley requested review of this revision.Feb 13 2020, 10:58 PM
epriestley updated this revision to Diff 50019.Feb 13 2020, 11:01 PM
  • Make "--clean" work.
  • Make creation flow minimally work.
Harbormaster completed remote builds in B23845: Diff 50019.Feb 13 2020, 11:02 PM
epriestley added a child revision: D20993: Port "arc version" to Toolsets.Feb 13 2020, 11:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 14 2020, 5:15 PM
Closed by commit rARCcf9469e0d10b: Port "arc liberate" to Toolsets (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCcf9469e0d10b: Port "arc liberate" to Toolsets.

Revision Contents
Changeset List

Diff 50019

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/toolset/workflow/ArcanistArcWorkflow.php

Loading...
View Options

src/workflow/ArcanistLiberateWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility