Differential D20964

Update GitHub API calls to use "Authorization" header instead of "access_token" URI parameter
ClosedPublic
Actions

Authored by epriestley on Feb 4 2020, 3:51 PM.

Tags

None

Referenced Files

	F19083154: D20964.id49955.diff
	Tue, Dec 2, 12:31 PM

	F19055940: D20964.diff
	Fri, Nov 28, 6:42 PM

	F19037218: D20964.id49955.diff
	Tue, Nov 25, 10:45 PM

	F19025072: D20964.diff
	Mon, Nov 24, 5:27 AM

	F19010641: D20964.diff
	Sat, Nov 22, 5:56 AM

	F19010171: D20964.id49955.diff
	Sat, Nov 22, 2:37 AM

	F18985321: D20964.id49954.diff
	Mon, Nov 17, 12:58 PM

	F18877827: D20964.id49954.diff
	Thu, Nov 6, 12:17 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13485: Update GitHub integration for "access_token" deprecation changes
Commits: rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"…

Summary

Fixes T13485. GitHub has deprecated the "access_token" URI parameter for API authentication. Update to "Authorization: token ...".

Test Plan

Linked and unlinked a GitHub account locally.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 4 2020, 3:51 PM

Harbormaster completed remote builds in B23779: Diff 49954.Feb 4 2020, 3:53 PM

epriestley requested review of this revision.Feb 4 2020, 3:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 3:58 PM

Closed by commit rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"….

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

adapter/

PhutilGitHubAuthAdapter.php

6 lines

Diff 49955

View Options

src/applications/auth/adapter/PhutilGitHubAuthAdapter.php

Update GitHub API calls to use "Authorization" header instead of "access_token" URI parameterClosedPublicActions