Differential D20964

Update GitHub API calls to use "Authorization" header instead of "access_token" URI parameter
ClosedPublic
Actions

Authored by epriestley on Feb 4 2020, 3:51 PM.

Tags

None

Referenced Files

	F19827834: D20964.id49955.diff
	Mar 9 2026, 1:19 PM

	F19826160: D20964.id.diff
	Mar 8 2026, 5:47 PM

	F19809748: D20964.diff
	Mar 3 2026, 2:49 PM

	F19809743: D20964.diff
	Mar 3 2026, 2:44 PM

	F19807484: D20964.diff
	Mar 3 2026, 3:09 AM

	F19530268: D20964.id49955.diff
	Jan 19 2026, 9:43 PM

	F19529595: D20964.id49954.diff
	Jan 19 2026, 5:17 PM

	F19515643: D20964.id49955.diff
	Jan 14 2026, 2:21 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13485: Update GitHub integration for "access_token" deprecation changes
Commits: rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"…

Summary

Fixes T13485. GitHub has deprecated the "access_token" URI parameter for API authentication. Update to "Authorization: token ...".

Test Plan

Linked and unlinked a GitHub account locally.

Diff Detail

Repository

rP Phabricator

Branch

github1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23779
Build 32700: Run Core Tests
Build 32699: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 4 2020, 3:51 PM

Harbormaster completed remote builds in B23779: Diff 49954.Feb 4 2020, 3:53 PM

epriestley requested review of this revision.Feb 4 2020, 3:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 3:58 PM

Closed by commit rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"….

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

adapter/

PhutilGitHubAuthAdapter.php

6 lines

Diff 49954

View Options

src/applications/auth/adapter/PhutilGitHubAuthAdapter.php

Update GitHub API calls to use "Authorization" header instead of "access_token" URI parameterClosedPublicActions