Page MenuHomePhabricator

Fix an issue where the last line of block-based diffs could be incorrectly hidden
ClosedPublic

Authored by epriestley on Jan 30 2020, 4:17 PM.
Tags
None
Referenced Files
F15461697: D20959.id49934.diff
Tue, Apr 1, 10:26 AM
F15455196: D20959.id.diff
Sat, Mar 29, 10:48 PM
F15454130: D20959.id49935.diff
Sat, Mar 29, 4:29 PM
F15443800: D20959.diff
Thu, Mar 27, 6:15 AM
F15436838: D20959.id49935.diff
Tue, Mar 25, 4:39 PM
F15423056: D20959.diff
Sat, Mar 22, 12:32 PM
Unknown Object (File)
Feb 26 2025, 11:12 AM
Unknown Object (File)
Feb 25 2025, 11:12 AM
Subscribers
None

Details

Summary

Fixes T13468. See that task for discussion. The older source-rendering code mixes "line number" / "1-based" lists with "block number" / "0-based" lists and then has other bugs which cancel this out.

For block-based diffs, build an explicit block-based mask with only block numbers. This sort of sidesteps the whole issue.

Test Plan

Viewed the diff with the original reproduction case, plus various other block-based diffs, including one-block image diffs, in unified and side-by-side mode. Didn't spot any oddities.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable