Differential D20959

Fix an issue where the last line of block-based diffs could be incorrectly hidden
ClosedPublic
Actions

Authored by epriestley on Jan 30 2020, 4:17 PM.

Tags

None

Referenced Files

	F14090281: D20959.id49934.diff
	Sun, Nov 24, 4:56 PM

	F14089978: D20959.diff
	Sun, Nov 24, 2:56 PM

	Unknown Object (File)
	Mon, Nov 18, 5:38 PM

	Unknown Object (File)
	Sun, Nov 10, 7:38 AM

	Unknown Object (File)
	Sat, Nov 9, 4:00 PM

	Unknown Object (File)
	Tue, Oct 29, 10:28 PM

	Unknown Object (File)
	Sat, Oct 26, 4:45 PM

	Unknown Object (File)
	Oct 23 2024, 12:33 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13425: Support diffs between abstract block lists in the UI
T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view
Commits: rPccf28a81121e: Fix an issue where the last line of block-based diffs could be incorrectly…

Summary

Fixes T13468. See that task for discussion. The older source-rendering code mixes "line number" / "1-based" lists with "block number" / "0-based" lists and then has other bugs which cancel this out.

For block-based diffs, build an explicit block-based mask with only block numbers. This sort of sidesteps the whole issue.

Test Plan

Viewed the diff with the original reproduction case, plus various other block-based diffs, including one-block image diffs, in unified and side-by-side mode. Didn't spot any oddities.

Diff Detail

Repository

Branch

jupyter1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23760
Build 32676: Run Core Tests
Build 32675: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 30 2020, 4:17 PM

Harbormaster completed remote builds in B23760: Diff 49934.Jan 30 2020, 4:19 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 30 2020, 4:19 PM

epriestley requested review of this revision.

Closed by commit rPccf28a81121e: Fix an issue where the last line of block-based diffs could be incorrectly… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPccf28a81121e: Fix an issue where the last line of block-based diffs could be incorrectly….

epriestley added a task: T13425: Support diffs between abstract block lists in the UI.Jan 30 2020, 6:45 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

parser/

DifferentialHunkParser.php

64 lines

files/

diff/

PhabricatorDocumentEngineBlocks.php

11 lines

Diff 49934

src/applications/differential/parser/DifferentialHunkParser.php

Loading...

src/applications/files/diff/PhabricatorDocumentEngineBlocks.php

Loading...