Use same method to get object URI as used in DifferentialTransactionEditor and PhabricatorApplicationTransactionEditor
ClosedPublic
Actions

Authored by artms on Dec 9 2019, 11:27 AM.

Details

Reviewers

epriestley
Pawka

Group Reviewers

Blessed Reviewers

Commits

rP4cd333b33fb1: Use same method to get object URI as used in DifferentialTransactionEditor and…

Summary

Maniphest object has getURI method, let's use it

Test Plan

Create event in task - URI generated as expected in email notification

Diff Detail

Repository

rP Phabricator

Branch

maniphest_task_uri

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 23710
Build 32600: Run Core Tests
Build 32599: arc lint + arc unit

Event Timeline

artms created this revision.Dec 9 2019, 11:27 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 9 2019, 11:27 AM

Harbormaster completed remote builds in B23710: Diff 49885.Dec 9 2019, 11:28 AM

artms requested review of this revision.Dec 9 2019, 11:28 AM

Herald added a subscriber: Korvin. · View Herald TranscriptDec 9 2019, 11:28 AM

artms edited the test plan for this revision. (Show Details)Dec 9 2019, 11:31 AM

epriestley accepted this revision.Dec 9 2019, 6:38 PM

This revision is now accepted and ready to land.Dec 9 2019, 6:38 PM

Closed by commit rP4cd333b33fb1: Use same method to get object URI as used in DifferentialTransactionEditor and… (authored by artms). · Explain WhyDec 10 2019, 3:37 PM

This revision was automatically updated to reflect the committed changes.

artms added a commit: rP4cd333b33fb1: Use same method to get object URI as used in DifferentialTransactionEditor and….

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

editor/

ManiphestTransactionEditor.php

2 lines

Diff 49885

View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Use same method to get object URI as used in DifferentialTransactionEditor and PhabricatorApplicationTransactionEditorClosedPublicActions