Page MenuHomePhabricator
Differential D20867

Move Git-specific "arc land" parsing of "--onto" and "--remote" into GitLandEngine
ClosedPublic
Actions

Authored by epriestley on Oct 28 2019, 4:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 2:18 PM
Unknown Object (File)
Sat, Apr 6, 4:28 AM
Unknown Object (File)
Thu, Apr 4, 1:35 AM
Unknown Object (File)
Mon, Apr 1, 5:39 AM
Unknown Object (File)
Thu, Mar 28, 9:48 PM
Unknown Object (File)
Sat, Mar 23, 7:08 PM
Unknown Object (File)
Mar 5 2024, 5:58 AM
Unknown Object (File)
Feb 24 2024, 5:06 PM
View All 65 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13434: Support Perforce/Git in "arc land"
Commits
rARC9c7bbb760a8b: Move Git-specific "arc land" parsing of "--onto" and "--remote" into…
Summary

Ref T13434. Move some git-engine-specific handling of "arc land" arguments into the Git engine. This prepares to handle Perforce workflows.

Test Plan

Will "arc land" this change.

Diff Detail

Repository
rARC Arcanist
Branch
perforce1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23575
Build 32401: Run Core Tests
Build 32400: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 28 2019, 4:04 PM
Harbormaster completed remote builds in B23574: Diff 49745.Oct 28 2019, 4:04 PM
epriestley requested review of this revision.Oct 28 2019, 4:04 PM
epriestley updated this revision to Diff 49746.Oct 28 2019, 4:12 PM
  • Fix "$this" references so the code actually runs.
  • Used "arc land" to land changes.
Harbormaster completed remote builds in B23575: Diff 49746.Oct 28 2019, 4:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 28 2019, 6:24 PM
Closed by commit rARC9c7bbb760a8b: Move Git-specific "arc land" parsing of "--onto" and "--remote" into… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC9c7bbb760a8b: Move Git-specific "arc land" parsing of "--onto" and "--remote" into….

Revision Contents
Changeset List

PathSize
src/
land/
118 lines
21 lines
workflow/
132 lines

Diff 49746

View Options

src/land/ArcanistGitLandEngine.php

Loading...
View Options

src/land/ArcanistLandEngine.php

Loading...
View Options

src/workflow/ArcanistLandWorkflow.php

Loading...
Phabricator · Built by Phacility