Page MenuHomePhabricator
Differential D20859

Fix an error message when calling "transaction.search" with a non-transactional object PHID as an "objectIdentifier"
ClosedPublic
Actions

Authored by epriestley on Oct 17 2019, 4:16 PM.
Tags
None
Referenced Files
F13222576: D20859.diff
Sun, May 19, 3:46 AM
F13217826: D20859.diff
Sat, May 18, 8:20 AM
F13207601: D20859.id49729.diff
Thu, May 16, 1:09 AM
F13205242: D20859.diff
Wed, May 15, 1:37 AM
F13190648: D20859.id49728.diff
Sat, May 11, 12:48 PM
F13189492: D20859.diff
Sat, May 11, 6:06 AM
Unknown Object (File)
Wed, May 1, 12:22 AM
Unknown Object (File)
Sat, Apr 27, 8:44 AM
View All 55 Files
Subscribers
None

Details

Reviewers
None
Commits
rPd34dfa37461b: Fix an error message when calling "transaction.search" with a non-transactional…
Summary

See PHI1499. This error message doesn't provide parameters, and can be a little bit more helpful.

Test Plan

Screen Shot 2019-10-17 at 9.14.15 AM.png (1×1 px, 260 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 17 2019, 4:16 PM
Harbormaster completed remote builds in B23556: Diff 49728.Oct 17 2019, 4:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 17 2019, 4:18 PM
epriestley requested review of this revision.
Closed by commit rPd34dfa37461b: Fix an error message when calling "transaction.search" with a non-transactional… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPd34dfa37461b: Fix an error message when calling "transaction.search" with a non-transactional….

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
conduit/
7 lines

Diff 49729

View Options

src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility