Page MenuHomePhabricator
Differential D20859

Fix an error message when calling "transaction.search" with a non-transactional object PHID as an "objectIdentifier"
ClosedPublic
Actions

Authored by epriestley on Oct 17 2019, 4:16 PM.
Tags
None
Referenced Files
F14957036: D20859.id49729.diff
Sun, Feb 16, 2:55 AM
F14956494: D20859.id49729.diff
Sun, Feb 16, 2:20 AM
Unknown Object (File)
Sun, Feb 9, 8:17 AM
Unknown Object (File)
Sun, Feb 9, 8:17 AM
Unknown Object (File)
Sun, Feb 9, 8:17 AM
Unknown Object (File)
Sun, Feb 9, 8:17 AM
Unknown Object (File)
Thu, Jan 30, 1:13 PM
Unknown Object (File)
Sat, Jan 25, 5:57 AM
View All Files
Subscribers
None

Details

Reviewers
None
Commits
rPd34dfa37461b: Fix an error message when calling "transaction.search" with a non-transactional…
Summary

See PHI1499. This error message doesn't provide parameters, and can be a little bit more helpful.

Test Plan

Screen Shot 2019-10-17 at 9.14.15 AM.png (1×1 px, 260 KB)

Diff Detail

Repository
rP Phabricator
Branch
error1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23556
Build 32373: Run Core Tests
Build 32372: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 17 2019, 4:16 PM
Harbormaster completed remote builds in B23556: Diff 49728.Oct 17 2019, 4:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 17 2019, 4:18 PM
epriestley requested review of this revision.
Closed by commit rPd34dfa37461b: Fix an error message when calling "transaction.search" with a non-transactional… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPd34dfa37461b: Fix an error message when calling "transaction.search" with a non-transactional….

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
conduit/
7 lines

Diff 49728

View Options

src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility