Differential D20852

Support more than 9 portals
ClosedPublic
Actions

Authored by artms on Oct 2 2019, 7:31 PM.

Tags

None

Referenced Files

	F13145156: D20852.diff
	Fri, May 3, 8:48 AM

	Unknown Object (File)
	Sun, Apr 28, 10:11 AM

	Unknown Object (File)
	Sat, Apr 27, 6:50 PM

	Unknown Object (File)
	Fri, Apr 26, 6:46 PM

	Unknown Object (File)
	Thu, Apr 25, 2:37 AM

	Unknown Object (File)
	Sun, Apr 21, 10:12 PM

	Unknown Object (File)
	Mon, Apr 8, 5:37 PM

	Unknown Object (File)
	Feb 3 2024, 11:18 PM

View All 65 Files

Subscribers

Korvin

Details

Reviewers

epriestley
Pawka

Group Reviewers

Blessed Reviewers

Commits

rP960c447aab7f: Support more than 9 portals

Summary

If portal is created with id > 9 - then those portals are not reachable and always return 404.

Test Plan

Create at least 10 portals, 10th and rest of them will no longer return 404.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

artms created this revision.Oct 2 2019, 7:31 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 2 2019, 7:31 PM

Harbormaster completed remote builds in B23537: Diff 49709.Oct 2 2019, 7:32 PM

artms requested review of this revision.Oct 2 2019, 7:32 PM

Herald added a subscriber: Korvin. · View Herald TranscriptOct 2 2019, 7:32 PM

Thanks!

This revision is now accepted and ready to land.Oct 2 2019, 7:33 PM

Closed by commit rP960c447aab7f: Support more than 9 portals (authored by artms). · Explain WhyOct 2 2019, 7:36 PM

This revision was automatically updated to reflect the committed changes.

artms added a commit: rP960c447aab7f: Support more than 9 portals.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

application/

PhabricatorDashboardApplication.php

2 lines

Diff 49711

View Options

src/applications/dashboard/application/PhabricatorDashboardApplication.php

Support more than 9 portalsClosedPublicActions