Paths

Table of Contentst

Differential D20846

Fix "implode()" argument order in query string construction
ClosedPublic
Actions

Authored by epriestley on Sep 30 2019, 4:17 PM.

Tags

None

Referenced Files

	F21563104: D20846.diff
	Tue, Aug 4, 1:09 AM

	Unknown Object (File)
	Jul 4 2026, 12:42 PM

	Unknown Object (File)
	Jul 4 2026, 12:42 PM

	Unknown Object (File)
	Jul 4 2026, 12:42 PM

	Unknown Object (File)
	Jul 2 2026, 7:24 PM

	Unknown Object (File)
	Jun 30 2026, 4:34 PM

	Unknown Object (File)
	Jun 20 2026, 7:50 PM

	Unknown Object (File)
	Jun 7 2026, 2:17 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13428: PHP 7.4 now warns about "implode()" argument order
Commits: rPHU1750586fdc50: (stable) Promote 2019 Week 39
rPHU39ed96cd818a: Fix "implode()" argument order in query string construction

Summary

See https://discourse.phabricator-community.org/t/libphutil-exception-when-using-with-newer-php-deprecated-use-of-implode/3159.

Test Plan

Grepped for other calls to implode(), didn't catch any with bad order.

Diff Detail

Repository

Branch

util1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23517
Build 32322: Run Core Tests
Build 32321: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 30 2019, 4:17 PM

Harbormaster completed remote builds in B23517: Diff 49690.Sep 30 2019, 4:17 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 30 2019, 4:17 PM

epriestley requested review of this revision.

Closed by commit rPHU39ed96cd818a: Fix "implode()" argument order in query string construction (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPHU39ed96cd818a: Fix "implode()" argument order in query string construction.

epriestley added a commit: rPHU1750586fdc50: (stable) Promote 2019 Week 39.Sep 30 2019, 6:08 PM

epriestley added a task: T13428: PHP 7.4 now warns about "implode()" argument order.Oct 17 2019, 4:03 PM

Revision Contents
Changeset List

Path

Size

src/

utils/

2 lines

Diff 49690

src/utils/utils.php

Loading...