Differential D20841

Fix an issue where the "viewer" is not passed to Bulk Edit controls properly
ClosedPublic
Actions

Authored by epriestley on Sep 26 2019, 6:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 3, 8:06 AM

	Unknown Object (File)
	Thu, Apr 25, 2:03 AM

	Unknown Object (File)
	Tue, Apr 23, 7:50 PM

	Unknown Object (File)
	Tue, Apr 23, 4:02 PM

	Unknown Object (File)
	Tue, Apr 23, 2:20 AM

	Unknown Object (File)
	Fri, Apr 19, 6:32 AM

	Unknown Object (File)
	Apr 5 2024, 1:54 AM

	Unknown Object (File)
	Mar 30 2024, 6:42 AM

View All 80 Files

Subscribers

None

Details

Reviewers: None
Commits: rP7a0090f4d070: Fix an issue where the "viewer" is not passed to Bulk Edit controls properly

Summary

See PHI1442. If you have a bulk-editable datasource field with a composite datasource, it can currently fatal on the bulk edit workflow because the viewer is not passed correctly.

The error looks something like this:

Argument 1 passed to PhabricatorDatasourceEngine::setViewer() must be an instance of PhabricatorUser, null given, called in /Users/epriestley/dev/core/lib/phabricator/src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php on line 231

Test Plan

Configured a Maniphest custom field with a composite datasource, then tried a bulk edit. Things worked cleanly instead of fataling.

Diff Detail

Repository

Branch

bulk1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23510
Build 32310: Run Core Tests
Build 32309: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 26 2019, 6:47 PM

Harbormaster completed remote builds in B23510: Diff 49683.Sep 26 2019, 6:49 PM

epriestley requested review of this revision.Sep 26 2019, 6:49 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 26 2019, 7:03 PM

Closed by commit rP7a0090f4d070: Fix an issue where the "viewer" is not passed to Bulk Edit controls properly (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP7a0090f4d070: Fix an issue where the "viewer" is not passed to Bulk Edit controls properly.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

bulk/

type/

BulkTokenizerParameterType.php

3 lines

editengine/

PhabricatorEditEngine.php

4 lines

Diff 49683

src/applications/transactions/bulk/type/BulkTokenizerParameterType.php

Loading...

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...