Page MenuHomePhabricator

Fix an issue where the "viewer" is not passed to Bulk Edit controls properly
ClosedPublic

Authored by epriestley on Sep 26 2019, 6:47 PM.
Tags
None
Referenced Files
F18792809: D20841.diff
Thu, Oct 16, 8:15 PM
F18774000: D20841.diff
Thu, Oct 9, 2:17 PM
F18734068: D20841.id.diff
Tue, Sep 30, 10:47 PM
F18616481: D20841.diff
Sep 14 2025, 5:44 PM
F18584724: D20841.diff
Sep 11 2025, 1:27 PM
F18584683: D20841.diff
Sep 11 2025, 1:19 PM
F18584668: D20841.diff
Sep 11 2025, 1:14 PM
F18570795: D20841.id49684.diff
Sep 10 2025, 4:09 AM
Subscribers
None

Details

Summary

See PHI1442. If you have a bulk-editable datasource field with a composite datasource, it can currently fatal on the bulk edit workflow because the viewer is not passed correctly.

The error looks something like this:

Argument 1 passed to PhabricatorDatasourceEngine::setViewer() must be an instance of PhabricatorUser, null given, called in /Users/epriestley/dev/core/lib/phabricator/src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php on line 231

Test Plan

Configured a Maniphest custom field with a composite datasource, then tried a bulk edit. Things worked cleanly instead of fataling.

Diff Detail

Repository
rP Phabricator
Branch
bulk1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23510
Build 32310: Run Core Tests
Build 32309: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 26 2019, 7:03 PM
This revision was automatically updated to reflect the committed changes.