Page MenuHomePhabricator

Fix an issue where the "viewer" is not passed to Bulk Edit controls properly
ClosedPublic

Authored by epriestley on Sep 26 2019, 6:47 PM.
Tags
None
Referenced Files
F12838676: D20841.diff
Thu, Mar 28, 6:29 PM
Unknown Object (File)
Jan 31 2024, 9:04 PM
Unknown Object (File)
Jan 31 2024, 9:00 PM
Unknown Object (File)
Dec 25 2023, 1:26 AM
Unknown Object (File)
Dec 22 2023, 3:54 AM
Unknown Object (File)
Dec 20 2023, 3:31 PM
Unknown Object (File)
Dec 13 2023, 4:32 PM
Unknown Object (File)
Nov 30 2023, 6:25 AM
Subscribers
None

Details

Summary

See PHI1442. If you have a bulk-editable datasource field with a composite datasource, it can currently fatal on the bulk edit workflow because the viewer is not passed correctly.

The error looks something like this:

Argument 1 passed to PhabricatorDatasourceEngine::setViewer() must be an instance of PhabricatorUser, null given, called in /Users/epriestley/dev/core/lib/phabricator/src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php on line 231

Test Plan

Configured a Maniphest custom field with a composite datasource, then tried a bulk edit. Things worked cleanly instead of fataling.

Diff Detail

Repository
rP Phabricator
Branch
bulk1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23510
Build 32310: Run Core Tests
Build 32309: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 26 2019, 7:03 PM
This revision was automatically updated to reflect the committed changes.