Page MenuHomePhabricator

Fix an issue where the "viewer" is not passed to Bulk Edit controls properly
ClosedPublic

Authored by epriestley on Sep 26 2019, 6:47 PM.
Tags
None
Referenced Files
F17492314: D20841.diff
Wed, Jul 2, 3:36 PM
Unknown Object (File)
May 6 2025, 8:44 PM
Unknown Object (File)
Apr 18 2025, 9:27 AM
Unknown Object (File)
Apr 17 2025, 11:38 PM
Unknown Object (File)
Apr 15 2025, 4:52 PM
Unknown Object (File)
Apr 12 2025, 9:09 PM
Unknown Object (File)
Apr 9 2025, 10:27 AM
Unknown Object (File)
Apr 3 2025, 1:59 PM
Subscribers
None

Details

Summary

See PHI1442. If you have a bulk-editable datasource field with a composite datasource, it can currently fatal on the bulk edit workflow because the viewer is not passed correctly.

The error looks something like this:

Argument 1 passed to PhabricatorDatasourceEngine::setViewer() must be an instance of PhabricatorUser, null given, called in /Users/epriestley/dev/core/lib/phabricator/src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php on line 231

Test Plan

Configured a Maniphest custom field with a composite datasource, then tried a bulk edit. Things worked cleanly instead of fataling.

Diff Detail

Repository
rP Phabricator
Branch
bulk1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23510
Build 32310: Run Core Tests
Build 32309: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 26 2019, 7:03 PM
This revision was automatically updated to reflect the committed changes.