Page MenuHomePhabricator

When rendering Jupyter notebook diffs, split code inputs into individual blocks
ClosedPublic

Authored by epriestley on Sep 26 2019, 2:51 AM.
Tags
None
Referenced Files
F14090385: D20840.id49681.diff
Sun, Nov 24, 5:36 PM
F14090180: D20840.diff
Sun, Nov 24, 4:07 PM
F14089342: D20840.diff
Sun, Nov 24, 9:59 AM
Unknown Object (File)
Thu, Nov 21, 9:19 AM
Unknown Object (File)
Thu, Nov 14, 6:56 AM
Unknown Object (File)
Sun, Nov 10, 8:10 AM
Unknown Object (File)
Sat, Nov 9, 3:51 PM
Unknown Object (File)
Oct 20 2024, 11:20 PM
Subscribers
None

Details

Summary

Ref T13425. Currently, code inputs and all outputs are grouped into a single block. This is fine for display notebooks but not great for diffing notebooks.

Instead, split source code input into individual lines with one line per block, and each output into its own block.

This allows you to leave actual line-by-line inlines on source, and comment on outputs individually.

Test Plan

Screen Shot 2019-09-25 at 7.40.45 PM.png (542×872 px, 92 KB)

Diff Detail

Repository
rP Phabricator
Branch
jupyter11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23508
Build 32307: Run Core Tests
Build 32306: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 26 2019, 4:05 AM
This revision was automatically updated to reflect the committed changes.