Page MenuHomePhabricator
Differential D20823

Fix a cursor paging issue in Conduit call logs
ClosedPublic
Actions

Authored by epriestley on Sep 24 2019, 3:34 PM.
Tags
None
Referenced Files
F19004966: D20823.id49644.diff
Fri, Nov 21, 1:20 PM
F18992067: D20823.id49643.diff
Wed, Nov 19, 12:09 AM
F18985217: D20823.id49643.diff
Mon, Nov 17, 12:56 PM
F18980511: D20823.id49643.diff
Mon, Nov 17, 12:50 AM
F18952416: D20823.id.diff
Wed, Nov 12, 5:55 AM
F18942710: D20823.id49643.diff
Tue, Nov 11, 12:31 PM
F18849607: D20823.id.diff
Thu, Oct 30, 10:55 AM
F18845509: D20823.diff
Wed, Oct 29, 12:35 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13423: Conduit log paging is broken, fails with `Call to undefined method PhabricatorConduitLogQuery::withIDs` error
Commits
rPbe2a0f873368: Fix a cursor paging issue in Conduit call logs
Summary

Fixes T13423. The "Query" class for conduit call logs is missing a "withIDs()" method.

Test Plan

Paged through Conduit call logs.

Diff Detail

Repository
rP Phabricator
Branch
conduit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23470
Build 32250: Run Core Tests
Build 32249: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 24 2019, 3:34 PM
Harbormaster completed remote builds in B23470: Diff 49643.Sep 24 2019, 3:36 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2019, 3:36 PM
epriestley requested review of this revision.
Closed by commit rPbe2a0f873368: Fix a cursor paging issue in Conduit call logs (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPbe2a0f873368: Fix a cursor paging issue in Conduit call logs.

Revision Contents
Changeset List

PathSize
src/
applications/
conduit/
query/
13 lines

Diff 49643

View Options

src/applications/conduit/query/PhabricatorConduitLogQuery.php

Loading...
Phabricator · Built by Phacility