Differential D20823

Fix a cursor paging issue in Conduit call logs
ClosedPublic
Actions

Authored by epriestley on Sep 24 2019, 3:34 PM.

Tags

None

Referenced Files

	F14078540: D20823.diff
	Fri, Nov 22, 4:13 AM

	Unknown Object (File)
	Oct 21 2024, 10:42 AM

	Unknown Object (File)
	Oct 15 2024, 5:06 AM

	Unknown Object (File)
	Sep 10 2024, 6:30 AM

	Unknown Object (File)
	Sep 5 2024, 4:46 AM

	Unknown Object (File)
	Sep 1 2024, 8:08 AM

	Unknown Object (File)
	Aug 31 2024, 11:23 PM

	Unknown Object (File)
	Aug 31 2024, 12:14 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13423: Conduit log paging is broken, fails with `Call to undefined method PhabricatorConduitLogQuery::withIDs` error
Commits: rPbe2a0f873368: Fix a cursor paging issue in Conduit call logs

Summary

Fixes T13423. The "Query" class for conduit call logs is missing a "withIDs()" method.

Test Plan

Paged through Conduit call logs.

Diff Detail

Repository

rP Phabricator

Branch

conduit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23470
Build 32250: Run Core Tests
Build 32249: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 24 2019, 3:34 PM

Harbormaster completed remote builds in B23470: Diff 49643.Sep 24 2019, 3:36 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2019, 3:36 PM

epriestley requested review of this revision.

Closed by commit rPbe2a0f873368: Fix a cursor paging issue in Conduit call logs (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPbe2a0f873368: Fix a cursor paging issue in Conduit call logs.

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

query/

PhabricatorConduitLogQuery.php

13 lines

Diff 49643

View Options

src/applications/conduit/query/PhabricatorConduitLogQuery.php

Fix a cursor paging issue in Conduit call logsClosedPublicActions