Page MenuHomePhabricator

Give policy name rendering explicit "text name", "capability link", and "transaction link" pathways
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:46 PM.
Tags
None
Referenced Files
F15411279: D20804.diff
Wed, Mar 19, 8:58 AM
F15411228: D20804.diff
Wed, Mar 19, 8:55 AM
F15411166: D20804.diff
Wed, Mar 19, 8:53 AM
F15411161: D20804.diff
Wed, Mar 19, 8:52 AM
F15411030: D20804.diff
Wed, Mar 19, 8:47 AM
F15386008: D20804.id49608.diff
Fri, Mar 14, 11:51 PM
F15293861: D20804.id49600.diff
Wed, Mar 5, 5:17 AM
Unknown Object (File)
Tue, Feb 25, 4:03 PM
Subscribers
None

Details

Summary

Ref T13411. This cleans up policy name rendering. We ultimately render into three contexts:

  • Plain text contexts, like bin/policy show.
  • Transaction contexts, where we're showing a policy change. In these cases, we link some policies (like project policies and custom policies) but the links go directly to the relevant object or a minimal explanation of the change. We don't link policies like "All Users".
  • Capability contexts, where we're describing a capability, like "Can Push" or cases in Applicaitons. In these cases, we link all policies to the full policy explanation flow.
Test Plan
  • Used bin/policy show to examine the policy of an object with a project policy, no longer saw HTML.
  • Viewed the transaction logs of Applications (ModularTransactions) and Tasks (not ModularTransactions) with policy edits, including project and custom policies.
  • Clicked "Custom Policy" in both logs, got consistent dialogs.
  • Viewed application detail pages, saw all capabities linked to explanatory capability dialogs. The value of having this dialog is that the user can get a full explanation of special rules even if the policy is something mundane like "All Users".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable