Page MenuHomePhabricator

Give policy name rendering explicit "text name", "capability link", and "transaction link" pathways
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:46 PM.
Tags
None
Referenced Files
F12843969: D20804.diff
Thu, Mar 28, 11:12 PM
Unknown Object (File)
Thu, Mar 28, 6:33 AM
Unknown Object (File)
Dec 26 2023, 7:03 PM
Unknown Object (File)
Dec 26 2023, 1:40 AM
Unknown Object (File)
Dec 23 2023, 6:40 AM
Unknown Object (File)
Dec 13 2023, 9:38 AM
Unknown Object (File)
Dec 5 2023, 1:40 AM
Unknown Object (File)
Nov 30 2023, 3:01 AM
Subscribers
None

Details

Summary

Ref T13411. This cleans up policy name rendering. We ultimately render into three contexts:

  • Plain text contexts, like bin/policy show.
  • Transaction contexts, where we're showing a policy change. In these cases, we link some policies (like project policies and custom policies) but the links go directly to the relevant object or a minimal explanation of the change. We don't link policies like "All Users".
  • Capability contexts, where we're describing a capability, like "Can Push" or cases in Applicaitons. In these cases, we link all policies to the full policy explanation flow.
Test Plan
  • Used bin/policy show to examine the policy of an object with a project policy, no longer saw HTML.
  • Viewed the transaction logs of Applications (ModularTransactions) and Tasks (not ModularTransactions) with policy edits, including project and custom policies.
  • Clicked "Custom Policy" in both logs, got consistent dialogs.
  • Viewed application detail pages, saw all capabities linked to explanatory capability dialogs. The value of having this dialog is that the user can get a full explanation of special rules even if the policy is something mundane like "All Users".

Diff Detail

Repository
rP Phabricator
Branch
policy4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23425
Build 32184: Run Core Tests
Build 32183: arc lint + arc unit