Page MenuHomePhabricator

Update rendering of policy edit transactions in Applications
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:03 PM.
Tags
None
Referenced Files
F15380808: D20801.id49597.diff
Fri, Mar 14, 4:33 AM
Unknown Object (File)
Wed, Feb 26, 1:12 PM
Unknown Object (File)
Feb 9 2025, 8:07 AM
Unknown Object (File)
Feb 9 2025, 8:07 AM
Unknown Object (File)
Feb 9 2025, 8:07 AM
Unknown Object (File)
Jan 28 2025, 5:21 AM
Unknown Object (File)
Jan 25 2025, 5:44 AM
Unknown Object (File)
Jan 25 2025, 5:44 AM
Subscribers
None

Details

Summary

Ref T13411. Since circa D19829, transactions have rendered policy changes in a modern way, notably making "Custom Policy" clickable to show the policy rules.

Edit transactions in Applications still use a separate, older approach to render policies. This produces policy renderings which don't use modern quoting rules and don't link in a modern way.

Make Applications use the same rendering code that other transactions (like normal edit/view edits) use.

Test Plan

Edited policies in Applications, saw more useful transactions in the log. Clicked "Custom Policy" in the transaction log and got a useful explanation of the policy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:32 PM
This revision was automatically updated to reflect the committed changes.