Page MenuHomePhabricator

Update rendering of policy edit transactions in Applications
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:03 PM.
Tags
None
Referenced Files
F15601405: D20801.diff
Wed, May 14, 1:33 AM
Unknown Object (File)
Thu, May 8, 10:49 PM
Unknown Object (File)
Fri, Apr 25, 5:42 PM
Unknown Object (File)
Thu, Apr 24, 12:30 PM
Unknown Object (File)
Sun, Apr 20, 4:49 PM
Unknown Object (File)
Apr 14 2025, 1:20 AM
Unknown Object (File)
Apr 11 2025, 8:23 PM
Unknown Object (File)
Apr 1 2025, 9:47 AM
Subscribers
None

Details

Summary

Ref T13411. Since circa D19829, transactions have rendered policy changes in a modern way, notably making "Custom Policy" clickable to show the policy rules.

Edit transactions in Applications still use a separate, older approach to render policies. This produces policy renderings which don't use modern quoting rules and don't link in a modern way.

Make Applications use the same rendering code that other transactions (like normal edit/view edits) use.

Test Plan

Edited policies in Applications, saw more useful transactions in the log. Clicked "Custom Policy" in the transaction log and got a useful explanation of the policy.

Diff Detail

Repository
rP Phabricator
Branch
policy1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23422
Build 32178: Run Core Tests
Build 32177: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:32 PM
This revision was automatically updated to reflect the committed changes.