Page MenuHomePhabricator

Update rendering of policy edit transactions in Applications
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 10:30 AM
Unknown Object (File)
Mon, Dec 16, 11:50 PM
Unknown Object (File)
Sat, Dec 14, 3:18 PM
Unknown Object (File)
Sat, Dec 14, 2:44 AM
Unknown Object (File)
Mon, Dec 9, 5:25 AM
Unknown Object (File)
Dec 4 2024, 1:30 AM
Unknown Object (File)
Dec 3 2024, 11:39 AM
Unknown Object (File)
Nov 4 2024, 3:57 AM
Subscribers
None

Details

Summary

Ref T13411. Since circa D19829, transactions have rendered policy changes in a modern way, notably making "Custom Policy" clickable to show the policy rules.

Edit transactions in Applications still use a separate, older approach to render policies. This produces policy renderings which don't use modern quoting rules and don't link in a modern way.

Make Applications use the same rendering code that other transactions (like normal edit/view edits) use.

Test Plan

Edited policies in Applications, saw more useful transactions in the log. Clicked "Custom Policy" in the transaction log and got a useful explanation of the policy.

Diff Detail

Repository
rP Phabricator
Branch
policy1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23422
Build 32178: Run Core Tests
Build 32177: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:32 PM
This revision was automatically updated to reflect the committed changes.