Page MenuHomePhabricator

Update rendering of policy edit transactions in Applications
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:03 PM.
Tags
None
Referenced Files
F18785934: D20801.id49605.diff
Tue, Oct 14, 3:45 PM
F18779885: D20801.id.diff
Sat, Oct 11, 3:41 PM
F18755910: D20801.diff
Sun, Oct 5, 8:13 AM
F18734032: D20801.id.diff
Tue, Sep 30, 10:47 PM
F18656984: D20801.id49597.diff
Sep 23 2025, 12:04 AM
F18570631: D20801.id49605.diff
Sep 10 2025, 4:00 AM
F18570630: D20801.id49597.diff
Sep 10 2025, 4:00 AM
F18567385: D20801.id.diff
Sep 9 2025, 3:44 PM
Subscribers
None

Details

Summary

Ref T13411. Since circa D19829, transactions have rendered policy changes in a modern way, notably making "Custom Policy" clickable to show the policy rules.

Edit transactions in Applications still use a separate, older approach to render policies. This produces policy renderings which don't use modern quoting rules and don't link in a modern way.

Make Applications use the same rendering code that other transactions (like normal edit/view edits) use.

Test Plan

Edited policies in Applications, saw more useful transactions in the log. Clicked "Custom Policy" in the transaction log and got a useful explanation of the policy.

Diff Detail

Repository
rP Phabricator
Branch
policy1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23422
Build 32178: Run Core Tests
Build 32177: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:32 PM
This revision was automatically updated to reflect the committed changes.