Differential D20794

Fix fatal during redirection safety check for searching for Phabricator base-uri with no trailing slash
ClosedPublic
Actions

Authored by epriestley on Sep 9 2019, 7:30 PM.

Details

Reviewers: None
Maniphest Tasks: T13412: Searching for the install URI with no trailing slash fatals
Commits: rPaaaea5759133: Fix fatal during redirection safety check for searching for Phabricator base…

Summary

Fixes T13412. If you search for "https://phabricator.example.com" with no trailing slash, we currently redirect you to "", which is fouled by a safety check in the redirection flow.

Test Plan

Searched for "https://local.phacility.com"; before: fatal in redirection; after: clean redirect.
Searched for other self-URIs, got normal redirects.

Diff Detail

Repository

rP Phabricator

Branch

redir1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23408
Build 32157: Run Core Tests
Build 32156: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 9 2019, 7:30 PM

Harbormaster completed remote builds in B23408: Diff 49583.Sep 9 2019, 7:31 PM

epriestley requested review of this revision.Sep 9 2019, 7:31 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 7:45 PM

Closed by commit rPaaaea5759133: Fix fatal during redirection safety check for searching for Phabricator base… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPaaaea5759133: Fix fatal during redirection safety check for searching for Phabricator base….

Revision Contents
Changeset List

Path

Size

src/

applications/

meta/

engineextension/

PhabricatorDatasourceURIEngineExtension.php

12 lines

Diff 49583

View Options

src/applications/meta/engineextension/PhabricatorDatasourceURIEngineExtension.php

Fix fatal during redirection safety check for searching for Phabricator base-uri with no trailing slashClosedPublicActions