Page MenuHomePhabricator

Allow bin/config to create config file
ClosedPublic

Authored by avivey on Sep 7 2019, 7:18 PM.
Tags
None
Referenced Files
F13158288: D20788.id49567.diff
Sun, May 5, 5:27 PM
Unknown Object (File)
Fri, May 3, 5:26 AM
Unknown Object (File)
Sat, Apr 27, 3:24 AM
Unknown Object (File)
Thu, Apr 25, 12:53 AM
Unknown Object (File)
Wed, Apr 24, 8:14 PM
Unknown Object (File)
Wed, Apr 24, 5:35 AM
Unknown Object (File)
Sat, Apr 20, 4:55 PM
Unknown Object (File)
Tue, Apr 16, 10:14 PM
Subscribers

Details

Summary

See D20779, https://discourse.phabricator-community.org/t/3089. bin/config set complains about
missing config file as if it's un-writable.

Test Plan

run bin/config set with missing, writable, unwritable conf.json and parent dir.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 23392
Build 32135: Run Core Tests
Build 32134: arc lint + arc unit

Event Timeline

avivey requested review of this revision.Sep 7 2019, 7:19 PM

assertWritable checks that the file exists and writable. There's assertWritableFile, but it's private, and it's being called anyway from setKeys.
This might be hiding some other strange conditions, but I couldn't think of any that don't end up just making the file un-writeable.

Oops -- I think this is a reasonable fix, thanks!

This revision is now accepted and ready to land.Sep 7 2019, 11:01 PM
This revision was automatically updated to reflect the committed changes.