Page MenuHomePhabricator

Make "bin/storage destroy" target individual hosts in database cluster mode
ClosedPublic

Authored by epriestley on Sep 4 2019, 5:08 PM.
Tags
None
Referenced Files
F13226747: D20784.diff
Sun, May 19, 11:06 PM
F13212289: D20784.diff
Fri, May 17, 6:33 AM
F13195836: D20784.diff
Sun, May 12, 10:39 PM
F13178518: D20784.diff
Wed, May 8, 8:28 PM
Unknown Object (File)
Apr 25 2024, 2:38 AM
Unknown Object (File)
Apr 17 2024, 2:59 PM
Unknown Object (File)
Apr 17 2024, 12:33 AM
Unknown Object (File)
Apr 6 2024, 3:49 AM
Subscribers
None

Details

Summary

Ref T13336. Currently, "bin/storage destroy" destroys every master. This is wonderfully destructive, but if replication fails it's useful to be able to destroy only a replica.

Operate on a single host, and require "--host" to target the operation in cluster mode, so bin/storage destroy --host dbreplica001 is a useful operation.

Test Plan

Ran bin/storage destroy with various flags locally. Will destroy secure002 and refresh replication.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 4 2019, 5:10 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.