Page MenuHomePhabricator

Make "bin/storage destroy" target individual hosts in database cluster mode
ClosedPublic

Authored by epriestley on Sep 4 2019, 5:08 PM.
Tags
None
Referenced Files
F13090922: D20784.diff
Thu, Apr 25, 2:38 AM
Unknown Object (File)
Wed, Apr 17, 2:59 PM
Unknown Object (File)
Wed, Apr 17, 12:33 AM
Unknown Object (File)
Sat, Apr 6, 3:49 AM
Unknown Object (File)
Tue, Apr 2, 1:40 AM
Unknown Object (File)
Fri, Mar 29, 11:55 AM
Unknown Object (File)
Mar 21 2024, 5:36 AM
Unknown Object (File)
Feb 7 2024, 8:30 PM
Subscribers
None

Details

Summary

Ref T13336. Currently, "bin/storage destroy" destroys every master. This is wonderfully destructive, but if replication fails it's useful to be able to destroy only a replica.

Operate on a single host, and require "--host" to target the operation in cluster mode, so bin/storage destroy --host dbreplica001 is a useful operation.

Test Plan

Ran bin/storage destroy with various flags locally. Will destroy secure002 and refresh replication.

Diff Detail

Repository
rP Phabricator
Branch
destroy2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23384
Build 32123: Run Core Tests
Build 32122: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 4 2019, 5:10 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.