Page MenuHomePhabricator

Make "bin/storage destroy" target individual hosts in database cluster mode
ClosedPublic

Authored by epriestley on Sep 4 2019, 5:08 PM.
Tags
None
Referenced Files
F21043075: D20784.diff
Tue, Jun 30, 7:00 AM
F21022061: D20784.diff
Mon, Jun 29, 3:04 PM
Unknown Object (File)
Tue, Jun 23, 2:43 AM
Unknown Object (File)
Tue, Jun 23, 1:16 AM
Unknown Object (File)
Mon, Jun 22, 5:58 PM
Unknown Object (File)
Sat, Jun 20, 1:15 AM
Unknown Object (File)
Fri, Jun 19, 8:24 PM
Unknown Object (File)
Apr 12 2026, 12:31 AM
Subscribers
None

Details

Summary

Ref T13336. Currently, "bin/storage destroy" destroys every master. This is wonderfully destructive, but if replication fails it's useful to be able to destroy only a replica.

Operate on a single host, and require "--host" to target the operation in cluster mode, so bin/storage destroy --host dbreplica001 is a useful operation.

Test Plan

Ran bin/storage destroy with various flags locally. Will destroy secure002 and refresh replication.

Diff Detail

Repository
rP Phabricator
Branch
destroy2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23384
Build 32123: Run Core Tests
Build 32122: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 4 2019, 5:10 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.