Paths

Table of Contentst

Differential D20743

Straighten out replication/cache behavior in "bin/storage dump"
ClosedPublic
Actions

Authored by epriestley on Aug 28 2019, 3:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 25, 5:39 PM

	Unknown Object (File)
	Mon, Dec 16, 2:59 PM

	Unknown Object (File)
	Sat, Dec 14, 7:38 AM

	Unknown Object (File)
	Nov 20 2024, 11:36 AM

	Unknown Object (File)
	Nov 15 2024, 11:44 PM

	Unknown Object (File)
	Nov 12 2024, 7:46 AM

	Unknown Object (File)
	Nov 8 2024, 9:52 AM

	Unknown Object (File)
	Oct 24 2024, 1:21 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE
Commits: rPc6642213d57f: Straighten out replication/cache behavior in "bin/storage dump"

Summary

Fixes T13336.

Prevent --no-indexes from being combined with --for-replica, since combining these options can only lead to heartbreak.
In --for-replica mode, dump caches too. See discussion in T13336. It is probably "safe" to not dump these today, but fragile and not correct.
Mark the "MarkupCache" table as having "Cache" persistence, not "Data" persistence (no need to back it up, since it can be fully regenerated from other datasources).

Test Plan

Ran bin/storage dump with various combinations of flags.

Diff Detail

Repository

Branch

cache1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23317
Build 32037: Run Core Tests
Build 32036: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 28 2019, 3:19 PM

Harbormaster completed remote builds in B23317: Diff 49458.Aug 28 2019, 3:21 PM

epriestley requested review of this revision.Aug 28 2019, 3:21 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 28 2019, 3:25 PM

Closed by commit rPc6642213d57f: Straighten out replication/cache behavior in "bin/storage dump" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPc6642213d57f: Straighten out replication/cache behavior in "bin/storage dump".

Revision Contents
Changeset List

Path

Size

src/

applications/

cache/

storage/

PhabricatorMarkupCache.php

4 lines

config/

schema/

PhabricatorConfigSchemaSpec.php

10 lines

infrastructure/

storage/

lisk/

4 lines

management/

workflow/

PhabricatorStorageManagementDumpWorkflow.php

23 lines

Diff 49458

src/applications/cache/storage/PhabricatorMarkupCache.php

Loading...

src/applications/config/schema/PhabricatorConfigSchemaSpec.php

Loading...

src/infrastructure/storage/lisk/LiskDAO.php

Loading...

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php

Loading...