Page MenuHomePhabricator

Straighten out replication/cache behavior in "bin/storage dump"
ClosedPublic

Authored by epriestley on Aug 28 2019, 3:19 PM.
Tags
None
Referenced Files
F15367333: D20743.diff
Tue, Mar 11, 5:26 PM
F15332791: D20743.id49458.diff
Fri, Mar 7, 8:22 PM
F15331899: D20743.id.diff
Fri, Mar 7, 3:02 PM
F15331529: D20743.id49459.diff
Fri, Mar 7, 11:06 AM
Unknown Object (File)
Tue, Feb 25, 10:40 PM
Unknown Object (File)
Tue, Feb 25, 10:38 PM
Unknown Object (File)
Tue, Feb 25, 10:37 PM
Unknown Object (File)
Tue, Feb 25, 10:37 PM
Subscribers
None

Details

Summary

Fixes T13336.

  • Prevent --no-indexes from being combined with --for-replica, since combining these options can only lead to heartbreak.
  • In --for-replica mode, dump caches too. See discussion in T13336. It is probably "safe" to not dump these today, but fragile and not correct.
  • Mark the "MarkupCache" table as having "Cache" persistence, not "Data" persistence (no need to back it up, since it can be fully regenerated from other datasources).
Test Plan

Ran bin/storage dump with various combinations of flags.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 28 2019, 3:25 PM
This revision was automatically updated to reflect the committed changes.