Page MenuHomePhabricator

Straighten out replication/cache behavior in "bin/storage dump"
ClosedPublic

Authored by epriestley on Aug 28 2019, 3:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 11:19 AM
Unknown Object (File)
Wed, Feb 28, 7:38 AM
Unknown Object (File)
Feb 16 2024, 9:12 PM
Unknown Object (File)
Jan 24 2024, 3:36 AM
Unknown Object (File)
Dec 25 2023, 4:03 AM
Unknown Object (File)
Dec 20 2023, 11:39 AM
Unknown Object (File)
Dec 3 2023, 8:11 AM
Unknown Object (File)
Nov 9 2023, 4:03 PM
Subscribers
None

Details

Summary

Fixes T13336.

  • Prevent --no-indexes from being combined with --for-replica, since combining these options can only lead to heartbreak.
  • In --for-replica mode, dump caches too. See discussion in T13336. It is probably "safe" to not dump these today, but fragile and not correct.
  • Mark the "MarkupCache" table as having "Cache" persistence, not "Data" persistence (no need to back it up, since it can be fully regenerated from other datasources).
Test Plan

Ran bin/storage dump with various combinations of flags.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 28 2019, 3:25 PM
This revision was automatically updated to reflect the committed changes.